The Twitter Bootstrap theme implements logic that places menu local tasks in a dropdown under the default local task's tab. For an example, see the screenshot below of the search page, where the "Content" tab is a dropdown for the "Content" and "User" local tasks.

twitter-bootstrap-dropdown.jpg

As mentioned in the screenshot, if you click on the "User" tab and want to go back to the "Content" tab, you have to first click on the "Content" tab and select the "Content" option in the dropdown. To me this interaction adds clicks and generally doesn't make sense for menu local tasks.

Comments

cpliakas’s picture

Status: Active » Needs review
StatusFileSize
new1.23 KB

The attached patch removes the logic that implements the dropdowns for local tasks.

Thanks for a great theme,
Chris

andregriffin’s picture

This seems like a reasonable fix. The dropdowns were never really useful except for the Devel menu, so +1 from me for committing this. I'll make the commit if there's another +1.

frankbaele’s picture

+1 from me, im commiting this

frankbaele’s picture

Status: Needs review » Fixed
cpliakas’s picture

Excellent. Thanks!

Chris

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

smoothify’s picture

Category: bug » task
Status: Closed (fixed) » Active
StatusFileSize
new2.54 KB

Removing this code left some orphan code in place. In bootstrap_preprocess_page, _bootstrap_local_tasks is called to populate the dropdown menu items. This means an expensive database call to the menu router table that is no longer necessary.

Here is a patch that removes them.

smoothify’s picture

Status: Active » Needs review
andregriffin’s picture

Status: Needs review » Fixed

Good catch. Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.