Download & Extend
Edit » Issues

Use <button> for elements that are buttons

Posted by jessebeach on November 26, 2012 at 8:57pm
Project:Edit
Version:7.x-1.x-dev
Component:Accessibility
Category:task
Priority:normal
Assigned:Wim Leers
Status:closed (fixed)
Issue tags:a11y, Edit D7 Backport

Issue Summary

Instead of a link <a> element, use buttons <button> for things that are buttons.

Screenshot of a page in edit mode. The Save link is indicated as well as the DevTools where the link is highlighted in the DOM structure.

AttachmentSize
edit-module-buttons-for-buttons.png72.74 KB
Login or register to post comments

Comments

#1

Posted by Wim Leers on November 27, 2012 at 4:05pm
Component:Code» Accessibility

#2

Posted by Wim Leers on November 27, 2012 at 7:38pm
Assigned to:Anonymous» Wim Leers

#3

Posted by Wim Leers on November 28, 2012 at 11:34am
Version:8.x-1.x-dev» 7.x-1.x-dev
Status:active» patch (to be ported)

Done. Pixel-for-pixel identical styling is maintained, but required more than just CSS selector changes.

http://drupalcode.org/project/edit.git/commit/9e8ca2c

#4

Posted by nod_ on January 11, 2013 at 10:20am
Status:patch (to be ported)» closed (fixed)

#1879824: Backport D8 Edit module to D7

#5

Posted by webchick on January 29, 2013 at 6:55pm
Issue tags:+Edit D7 Backport
nobody click here