Updated comment.module.dp5? [#185133]

Hi Christoph,

Would you be able to release a new version of comment.module.dp5 that is based on the new comment.module that comes with Drupal 5.3? It's my understanding that the comment.module was updated somewhat (at least one security vulnerability was quashed) with the new release.

Here are the updates to comment.module in Drupal 5.3 (all the ones I could find, anyway):

http://drupal.org/node/184354
http://drupal.org/node/180559
http://drupal.org/node/63990
http://drupal.org/node/183390

I need to upgrade my site for security reasons, but I don't want to lose the functionality provided by Comment Notify (thanks for an awesome module, by the way). I've struggled to look at the code, but I'm a novice at PHP and the logic of your modifications is not immediately apparent to me.

BTW - I suppose it's possible that your gripes with the existing comment.module have been addressed with this new release.

Thanks again.

Comment	File	Size	Author
#5	comment_notify_patch_to_comment.patch	693 bytes	greggles

Comments

Comment #1

WildBill commented 30 October 2007 at 13:56

Status:

Active

» Patch (to be ported)

Okay, I just added the else function described at the node below to the new v5.3 comment.module, and it seems to be working fine now.

http://drupal.org/node/156475

Comment #2

junyor commented 2 November 2007 at 02:53

It would be much, much better if this module included a patch for the core module rather than a drop-in replacement for the core module, especially if it isn't actively maintained.

Comment #3

ablivio commented 13 January 2008 at 18:59

To clarify things: the file comment.module.dp5 is based on the comment.module published with Drupal 5.1:
$Id: comment.module,v 1.520.2.1 2007/01/23 19:11:43 dries Exp $

The patch is pretty simple. In the comment_save() function, the following section:

      if ($status == COMMENT_NOT_PUBLISHED) {
        drupal_set_message(t('Your comment has been queued for moderation...[truncated]
      }
      return $edit['cid'];

has an additional 'else' clause:

      if ($status == COMMENT_NOT_PUBLISHED) {
        drupal_set_message(t('Your comment has been queued for moderation...[truncated]
      }
      else
      {
        comment_invoke_comment($edit, 'publish');
      }

Therefore, it's pretty easy to patch yourself the latest version of comment.module:

you find the "COMMENT_NOT_PUBLISHED" string
you add the else { comment_invoke_comment($edit, 'publish'); } line just before the return $edit['cid'];
you're done!

By the way, this modification has been committed in Drupal 6. :-)