Closed (fixed)
Project:
mothership
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Nov 2012 at 09:36 UTC
Updated:
15 Aug 2014 at 05:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mojzis commenteddefining selectivizr. not sure about performance, though.
Comment #2
mojzis commentedsorry about all the extra lines - there were some extra whitespaces that my proactive editor removed :)
Comment #3
the_g_bomb commentedPatch applies cleanly and removes the error message from what I can tell. Haven't tested much further than that though.
Comment #4
Funksmaname commentedhey, this patch changed the error line number (66), but I still get errors... any ideas??
in fact, it's made the error appear 13 times repeated, instead of once...
Comment #5
mortendk commentedhmm cant reproduce this
Comment #6
p0pemar1naru commentedIt's under hook_preprocess, attached to hook "maintenance_page" #521. The var is indeed uninitialized. Even my Netbeans editor complained about it when I opened the file :(
PHP will throw this NOTICE only when Maintenance mode is active.
The most non-intrusive fix that I can think of: $vars['selectivizr'] = @$selectivizr; OR @$vars['selectivizr'] = $selectivizr;
Add the @ in front of the var declaration at line #521.
Instead of declaring the var, I would just say ignore the Notice. Most probably the theme devs will declare it on the new version, so this hotfix won't affect the overall theme code in any way.
Comment #7
rooby commentedThis is still a problem.
Comment #8
rooby commentedCurrent patch is full of unrelated changes.
Comment #9
rooby commentedHere is a patch for latest dev.
The approach is a bit different to the previous one to remove the reference to a never used variable and not run selectivizr related code for template files that are unrelated to it.
Comment #10
rooby commentedActually I may as well fix whitespace errors and duplicate semicolons in the code block that was moved.
Comment #11
mparker17Code looks good.
Works for me!
Comment #12
cinnamon commentedI second that, it fixes the notice and also applies just fine on current release.
Comment #15
realityloop commented