Comments

scottm316’s picture

Status: Active » Needs review
StatusFileSize
new26.21 KB

This is done using suggestions from the coder module. Code changes based on notices and warnings found at or above "minor" severity level in the coder module. Mostly just a whitespace and commenting cleanup, but it would be nice to move forward writing patches against the cleaner code.

scottm316’s picture

Just testing another patch.

Status: Needs review » Needs work

The last submitted patch, bbb-coder-standards-1851622-1.patch, failed testing.

scottm316’s picture

Status: Needs work » Needs review

#1: bbb-coder-standards-1851622-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, bbb-coder-standards-1851622-1.patch, failed testing.

scottm316’s picture

Status: Needs work » Needs review
Issue tags: +Novice
StatusFileSize
new24.27 KB

Re-rolled using the updated code from earlier. Mostly just spacing issues throughout.

Ash07’s picture

StatusFileSize
new30.95 KB

Testing it with Coder only give me warnings just in bbb.module, here is my patch with corrections.

Status: Needs review » Needs work

The last submitted patch, bbb-coder-standards-1851622-2.patch, failed testing.

Ash07’s picture

Ash07’s picture

Sorry for the previous post

Ash07’s picture

StatusFileSize
new2.01 KB
scottm316’s picture

Status: Needs work » Closed (fixed)

I've applied the patch in #6 and it is now part of the latest 7.x-1.x-dev release. Any further patches written against *this* release (Jan 10/2013) are super appreciated. I'm going to close this issue. Feel free to re-open or (preferably) open a new issue for Drupal coding standards at a later time following some more dev.

scottm316’s picture

Issue summary: View changes

Added another filename.