Download & Extend
Issues

hook_menu doesn't mention 'expanded'

Posted by joachim on November 27, 2012 at 2:39pm
Project:Drupal core
Version:7.x-dev
Component:documentation
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7, Novice

Issue Summary

API page: http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

Enter a descriptive title (above) relating to hook_menu, then describe the problem you have found:

As mentioned in http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct..., this property is not mentioned in the docs. I can confirm it works on D7.

Login or register to post comments

Comments

#1

Posted by jhodgdon on November 27, 2012 at 3:56pm

What does this property do?

#2

Posted by joachim on November 27, 2012 at 4:08pm

If set, and if a menu link is provided for this menu item (as a result of other properties), then the menu link is always expanded, equivalently to its 'always expanded' checkbox being set in the UI.

#3

Posted by jhodgdon on November 27, 2012 at 7:01pm
Issue tags:+Novice

OK, thanks! Sounds like a good Novice project to add this to the documentation.

#4

Posted by blake.thompson on December 11, 2012 at 6:51pm
Status:active» needs review

First ever attempt at a patch, adding documentation for 'expanded' property in hook_menu.

AttachmentSizeStatusTest resultOperations
drupal-hook-menu-expanded-property-1851788-4.patch967 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-hook-menu-expanded-property-1851788-4.patch. Unable to apply patch. See the log in the details link for more information.View details

#5

Posted by jhodgdon on December 12, 2012 at 3:45pm
Status:needs review» needs work

Thanks! The only thing is that "item" is misspelled as "tem" near the beginning of the second line. Looks like you figured out the patch process though, and other than that, I think the wording is good and it's ready to go in.

#6

Posted by blake.thompson on December 12, 2012 at 5:34pm
Status:needs work» needs review

Correcting spelling error.

AttachmentSizeStatusTest resultOperations
drupal-hook-menu-expanded-property-1851788-6.patch968 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 49,305 pass(es).View details

#7

Posted by jhodgdon on December 14, 2012 at 4:13am
Status:needs review» reviewed & tested by the community

That version looks fine, thanks!

#8

Posted by Dries on December 14, 2012 at 3:10pm
Status:reviewed & tested by the community» fixed

Committed to 8.x. Thanks.

#9

Posted by jhodgdon on December 14, 2012 at 4:58pm
Version:8.x-dev» 7.x-dev
Status:fixed» patch (to be ported)

#10

Posted by cck on January 7, 2013 at 1:52am
Assigned to:Anonymous» cck
Status:patch (to be ported)» needs review

7.x version patch ported from drupal-hook-menu-expanded-property-1851788-6.patch

AttachmentSizeStatusTest resultOperations
drupal-hook-menu-expanded-property-1851788-9.patch938 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 39,788 pass(es).View details

#11

Posted by jhodgdon on January 8, 2013 at 12:41am
Assigned to:cck» jhodgdon
Status:needs review» reviewed & tested by the community

Thanks! I'll get this committed shortly.

#12

Posted by blacklabel_tom on January 8, 2013 at 10:48am

#4: drupal-hook-menu-expanded-property-1851788-4.patch queued for re-testing.

#13

Posted by jhodgdon on January 9, 2013 at 12:17am
Assigned to:jhodgdon» Anonymous
Status:reviewed & tested by the community» fixed

Committed to 7.x. Thanks again!

#14

Posted by System Message on January 23, 2013 at 12:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.