Crontab Manager

auto review :
http://ventral.org/pareview/httpgitdrupalorgsandboxlaborb1851792git
you have some errors , first fix them
manual review :
in your crontab_manager.config.inc
in this section :

/**
 * @file
 * config file for crontab_manager,  $preset_options stores different preset names,
 * $preset_content stores the data of the different presets.
 */

when you want explain about a parameter you should use @param ...

and some thing about .info file : it's not necessary to add version , drupal.org system will add it.
and also i think there is no need to add .module file in files[]

thank you ,
Mohsen

HI,

First of all you should have to fixed this issue

The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

remotes/origin/7.x-0.8

Thanks
Alok

1. As for now, there are still some comments in lines of more than 80 characters. See http://ventral.org/pareview/httpgitdrupalorgsandboxlaborb1851792git
2. The git instructions are wrong. What is the branch 7.x-0.8 ?
3. Please check your spelling in all your files. In the project page you have misspelled words such as 'imediatly', 'shure' and 'reqired'. Also, you should use 'crontab files' or 'cron jobs' instead of 'Crontabfiles', 'crontab-file' or 'cronjobs', etc. (Note that I'm not the best to tell that, my English is horrible... :)
4. Your commits should have more descriptive messages. It doesn't make a lot of sense to have 10 commits with the message 'bugfixes'. Also, a commit should target one specific thing.
5. In function crontab_manager_timevalidate(), I'd replace every $return = FALSE; with return FALSE; and just return TRUE at the end (and drop the initial $return = TRUE;). A lot easier to follow.
6. If you align the arrays in function crontab_manager_form(), please do it consistently.
7. IMHO you should write in the README and in the project page the risks of using this module.

added Sandbox link

1. plz add Requirements to README file like having webserver edit permissions to cron tab file.

Hi,

I gonna try to be complementary with other reviews.

My PAReview test returns a small issue: http://ventral.org/pareview/httpgitdrupalorgsandboxlaborb1851792git

README.txt: 37 | ERROR | Files must end in a single new line character

In the README.txt file, I would expect more details about the Risk of use and Context where to use it or not:

1. I guess this module concerns only LAMP server: you should be specific about this as Drupal is not LAMP specific. And if this is not the case, you should definitely explain how to use it on Mac or Windows ;-)
2. System user: there is a crontab by user, so which user will be used? Is it Apache user? Or account user on mutual hosting? Should we have a variable to identify the right user?
3. Considering the different scenarii that could happen about cron settings: http://drupal.org/node/23714 . What is compatible with this module? What is not?
4. If a crontab exists when enabling the module: can we modify it? Is this a risk for other cron settings for other software on the same server?

It seems the values are tested at form_validate(), but are not filtered at all before saving. I did not find any trace of the following functions in the code: check_*(),, filter_*(). You might consider using check_plain() before saving to file.

Hoping this will help.
Regards,

Alexandre

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (found some problems with the project) or "reviewed & tested by the community" (found no major flaws).

changed typos.