Only show Whizzywig editor on specified textareas option causes problem with config page

Well, here's what I did:

Starting from my existing DB / Drupal install, which is
Drupal 5.2 (PHP5)
Modules: CCK stuff, Views stuff, Devel, Views_filterblock, insert_block

1. Install whizzywig module
2. enable whizzywig
3. go to config at admin/settings/whizzywig
4. click "Visibility Settings" and the "Only ..." radio button
enter a couple of things into the box
5. Save configuration

I hardcoded into the module to never show the editor in the Whizzywig 'Visibility settings' textareas

Very very weird. I am attaching a screenshot showing what happens to the toolbar settings after I do this. Similar things happen to the Visibility textareas.

OK, I tried on my other install and I am still having exactly the same problems. So now I am looking at the module code hoping to spot something ... a fresh pair of eyes.

This code does not look right to me, in the function _whizzywig_validate_element_id. I am adding comments to highlight where I think the problem is:

  // exclude some textfields that we need on the settings page from showing the editor
  array_push($values_arr, 'edit-whizzywig-visibility-id-val');
  array_push($values_arr, 'edit-whizzywig-visibility-path-val');
  array_push($values_arr, 'edit-whizzywig-toolbar-buttons-list');
  if (variable_get('whizzywig_visibility_id', 0) == 0) {
    // don't show editor if id is found in values
       ... (code deleted) ...
  }
  else{
    // only show editor if id is found in values
    if (in_array($id, $values_arr)) {     // In this condition, the settings form will ALWAYS use Whizzywig
      $valid = true;
    }
  }

It seems to me you want the array_push lines inside the "if" in the code block above. OK, I'm trying it.

It works to solve this bug, at least! So here's the code diff:

386a387,390
>   // exclude some textfields that we need on the settings page from showing the editor
>   array_push($values_arr, 'edit-whizzywig-visibility-id-val');
>   array_push($values_arr, 'edit-whizzywig-visibility-path-val');
>   array_push($values_arr, 'edit-whizzywig-toolbar-buttons-list');
388,391d391
<     // exclude some textfields that we need on the settings page from showing the editor
<     array_push($values_arr, 'edit-whizzywig-visibility-id-val');
<     array_push($values_arr, 'edit-whizzywig-visibility-path-val');
<     array_push($values_arr, 'edit-whizzywig-toolbar-buttons-list');

It is difficult to see, but I have moved these 4 lines of code into the "if" that used to be just below them.