When just users are logged on, and a user is logged on to the site from several locations, the Who's Online block will show duplicates. This patch fixes it.

CommentFileSizeAuthor
user.module_77.patch866 byteshba

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (works as designed)

But why shouldn't the user be displayed as many times as he's logged in? The real fix is to remove session a if the user logs into session b with controls added for the admin to decide if multiple user sessions should be allowed; which is a new feature.

hba’s picture

hba commented
Status: Closed (works as designed) » Needs review

If this is by design, it's fairly weird.

The block should, as I see it, be a quick list to see who of your fellow members are online. Nobody (except the admins) cares about if they are logged into several sessions.

hazexp’s picture

hazexp commented

I've noticed this issue occurring on a couple of Drupal sites that I work with.

I think that hba is right on this one earnie. Reason being, when I see a Who's Online block, I don't want to show the usernames for every active session that my users have, I just want to show all usernames that have at least one active session.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Closed (works as designed)

The only way to implement peer-to-peer applications is by session. You need to be able to identify each unique session and not each unique user. So if I have Who's Online and want to use a peer-to-peer application I need to be able to ping the user at each session.

Anonymous’s picture

Anonymous (not verified) commented
Status: Closed (works as designed) » Reviewed & tested by the community

On second thought. Those peer-to-peer applications can do it themselves.

JirkaRybka’s picture

JirkaRybka commented

Possible duplicate: http://drupal.org/node/107051

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Needs review

I do not see any comments here which make me believe someone, other than the writer, has tested this patch.

JHeffner’s picture

JHeffner commented

The patch works under 5.3. It was related to an earlier problem in http://drupal.org/node/107051 and was introduced by an attempt for postgres compatibility I believe. The patch keeps popping back up ever since revision 5.1, since it hasn't been committed yet.

JHeffner’s picture

JHeffner commented

Can someone Please submit this? It popped up again in 5.4/5.5

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Closed (duplicate)

Duplicate of http://drupal.org/node/107051.