now that http://drupal.org/node/179772 is committed, it'd be nice if the "File attachments" fieldset was always expanded when creating issues or comments on issues.

CommentFileSizeAuthor
#4 project_issue_file_attach_fieldset_expanded-2.patch1.08 KBdww
#3 attachment_expand.patch713 bytesChrisKennedy
project_issue_file_attach_fieldset_expanded.patch1.26 KBdww

Comments

hunmonk’s picture

hunmonk commented
Status: Needs review » Reviewed & tested by the community

code looks good. works as advertised.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Thanks.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Fixed » Needs review
StatusFileSize
new attachment_expand.patch713 bytes

I don't think it should be expanded if we're on the first page of the issue form, when the project hasn't been selected yet. Here is one way to fix this, although there is probably a better variable to check for than a form element.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new project_issue_file_attach_fieldset_expanded-2.patch1.08 KB

Good point, Chris, thanks. I forgot about that multi-page form, since I always submit directly from a project. ;)

IMHO, here's a better approach: we should just unset($form['attachments']) entirely if we're on page 1. I agree, there might be a cleaner way to test what page we're on, but I'm not sure I really care, especially since it's all going to change when we port to D6 FAPI, anyway...

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Reviewed & tested by the community

Yeah removing it entirely does seem good.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.