Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
27 Nov 2012 at 18:25 UTC
Updated:
29 Jul 2014 at 21:35 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Grayside commentedComment #2
sunThis is just the first part only... now I remember why I left that out of the original issue/patch... ;)
Comment #3
sunx-post.
Comment #5
tkoleary commented@sun Could we also please only make the first summary/details on a page #open TRUE, and the successive ones #open FALSE? Opening them all kind of defeats the purpose right?
Comment #6
sun@tkoleary: The open attribute of details is controlled by each element on its own, by design. Whether it makes sense to open details is implementation and use-case-specific. Currently, we still have a lot of #type details elements that shouldn't be details in the first place though. They should be fieldsets or not grouped at all. Perhaps you're referring to those.
Comment #7
tim.plunkett#1886728: Switch from details to fieldset when collapsing isn't needed is an example of something that should be a fieldset again
Comment #8
yesct commentedYes, #6 makes sense.
Comment #9
tkoleary commented@sun I see. I thought that summary and details was an effort to make us more semantic and replace fieldsets. What are the criteria for when summary and details are appropriate vs fieldsets?
Comment #10
tkoleary commented@Sun Just looked at #1886728 which spurred me to think this through more deeply. Seems to me that the purpose of summary and details is to provide a semantic underpinning for things that expand to reveal more information. If that is the case then logic dictates we should be S&D everywhere in place of collapsible fieldsets (collapsible being the key word; styled divs that do not collapse would be fine).
Then the only remaining question is "what are the criteria for determining when detatils open='true' vs.'false' "? so we can implement that in core and add to HIG.
Comment #11
sunLet's handle these two tasks in two separate steps: #1892182: #type details: Rename #collapsed to #open
Comment #12
swentel commentedGreat!
Should be fine when it comes back.
Comment #13
nod_need reroll because of #1886728: Switch from details to fieldset when collapsing isn't needed Leaving RTBC, there is one #collapsible remove less from simpletest.pages.inc
Comment #14
sun#13: core-type-details-1852104-13.patch queued for re-testing.
Comment #16
nod_reroll
Comment #17
sunComment #18
star-szrNitpicking here but a couple of the docblocks could be re-wrapped, they wrap early. Interdiff is against #16.
Comment #20
star-szr#18: 1852104-18.patch queued for re-testing.
Comment #21
tstoecklerBack to RTBC. I reviewed the patch as well and agree with RTBC.
Comment #22
swentel commentedRe-rolled to fix merge conflict in NodeFormController.
Comment #23
dries commentedAlright, committed to 8.x. Thanks!
Comment #24.0
(not verified) commentedUpdated issue summary.
Comment #25
sun