Follow up for #1648930-250: Introduce configuration schema and use for translation 10.
Namespace docs standard fix in core/lib/Drupal/Core/Config/Config.php

Problem/Motivation

Originating issue had changes to this file, but only \namespace style fixes. It was cluttering the issue, and needed to be a follow-up.

Proposed resolution

Go through Config.php and fix it to be correct according to http://drupal.org/node/1354#namespaces

Remaining tasks

  • make initial patch of changes, keep focused on only docs and style updates. no refactoring. if refactoring is needed... make it a separate follow-up. :)
  • get review
  • iterate. patch, review.

Test bot coverage should be sufficient. No manual testing or screenshots needed.

User interface changes

no ui changes.

API changes

no api changes.

CommentFileSizeAuthor
#2 namespace_fix-1852236-2.patch4.9 KBryan.ryan

Comments

yesct’s picture

yesct commented
Issue tags: -sprint, -VDC
ryan.ryan’s picture

ryan.ryan commented
Assigned: Unassigned » ryan.ryan
Status: Active » Needs review
StatusFileSize
new namespace_fix-1852236-2.patch4.9 KB

Here's my first pass at this.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the cleanup!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: configuration system » documentation
Assigned: ryan.ryan » jhodgdon

This looks right to me, but this documentation standard keeps changing about every 15 seconds, so I can't remember what's right atm. :) Assigning to Jennifer to chime in.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Postponed

Neither can I. No one seems to be able to agree on a namespace usage in docs standard right now, so I'm postponing this for now. We should not be making any namepace cleanups until it is agreed upon, and at that time we should be doing larger patches than this one to clean it up. Here's the issue:
#1487760: [policy, no patch] Decide on documentation standards for namespaced items

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)

I think changing permissions here makes sense based on:
https://www.drupal.org/node/1487760#comment-9138221

Moving it from Postponed so it gets addressed.