#1535868: Convert all blocks into plugins does not include a CacheDecorator.
This is because right now, blocks are created on the fly under several different circumstances:

  • Views Wizard
  • Statistics config (admin/config/system/statistics)
  • Aggregator feeds
  • Custom blocks
  • Enabling new modules

All of the above would need to call something like drupal_container()->get('plugin.manager.block')->clearCachedDefinitions();

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Critical

First of all, we need to add CacheDecorator to BlockManager. Without it, displaying the home page after a new Standard profile install is 15x slower (1000ms) with this patch than with HEAD (70ms).

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +VDC, +Blocks-Layouts, +Plugin system
xjm’s picture

xjm
she/her
Primary language English
commented

The following blocks will need the definition cache invalidated when there are changes in the data that provides their definitions:

  1. AggregatorCategoryBlock
  2. AggregatorFeedBlock
  3. CustomBlock
  4. LanguageBlock
  5. MenuBlock
  6. SystemMenuBlock
  7. ViewsBlock
  8. ViewsExposedFilterBlock
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Postponed » Closed (duplicate)

This has now been added to the main patch.