Special characters get mangled [#1853196]

Currently any special characters get mangled during the table of contents generation process.

This occurs due to the fact that DOMDocument::loadHTML() is working with an incomplete HTML document (no <head>, <body>, etc.) which does not have an encoding specified so DOMDocument::loadHTML() uses its default setting of ISO-8859-1.

Comment	File	Size	Author
#6	simple_table_of_contents--special-characters-get-mangled-markup.patch	872 bytes	vadym.kononenko
#1	convert-special-characters-1853196-1.patch	1022 bytes	devin carlson

Comments

Comment #1

devin carlson commented 28 November 2012 at 19:25

Status:

Active

» Needs review

Status	File	Size
new	convert-special-characters-1853196-1.patch	1022 bytes

The "cleanest" fix seems to be encoding all HTML entities, generating the table of contents and then decoding the entities. This avoids concatenating metatags into the node's body field, building a fake HTML page, etc.

A patch to implement the fix.

Comment #2

devin carlson commented 28 November 2012 at 19:27

Status:

Needs review

» Fixed

Committed to 7.x-1.x.

Comment #3

12 December 2012 at 19:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

nomorerice commented 21 June 2013 at 09:14

Version:

» 7.x-1.1

I got same error as yours :

Warning: DOMDocument::createElement() [domdocument.createelement]: unterminated entity reference "&" , in simple_table_of_contents_generate_table_of_contents()

Patch: simple_table_of_contents.module Line 197

function simple_table_of_contents_generate_table_of_contents($html) {
...
// Iterate through the headings and build the table of contents
foreach ($headings as $node) {
$level = (int) $node->tagName[1];
-$name = $node->textContent;
+$name = htmlspecialchars($node->textContent);

Comment #5

proweb.ua commented 7 September 2013 at 21:04

Version:	7.x-1.1	» 7.x-1.x-dev
Assigned:	devin carlson	» proweb.ua
Status:	Closed (fixed)	» Needs work

Warning: DOMDocument::loadHTML() [domdocument.loadhtml]: Tag ... invalid in Entity, line: 1 в simple_table_of_contents_generate_table_of_contents() (рядок 108 із /var/www/sd/observer/public_html/sites/all/modules/simple_table_of_contents/simple_table_of_contents.module).

Warning: DOMDocument::loadHTML() [domdocument.loadhtml]: ID note already defined in Entity, line: 4422 в simple_table_of_contents_generate_table_of_contents() (рядок 108 із /var/www/sd/observer/public_html/sites/all/modules/simple_table_of_contents/simple_table_of_contents.module).

Warning: DOMDocument::loadHTML() [domdocument.loadhtml]: ID 14 already defined in Entity, line: 3320 в simple_table_of_contents_generate_table_of_contents() (рядок 108 із /var/www/sd/observer/public_html/sites/all/modules/simple_table_of_contents/simple_table_of_contents.module).

etc.