Reintroduce Views integration for statistics.module

I'm working on this one. Hopefully this will give us a better idea/template to base the other integration tests on.

Ok, here is a more generic test to just test the integration of the fields, so we have some coverage. I think we agree that creating views to cater for all filter/arg combinations isn't feasible. Also added a test for the AccessLogPath handler.

Without the annoying no newline..

Just some general cleanup

Ups totally wrong interdiff.

Yeah, those changes look like good ones to me. Just need to fix up that init() method I think...

Oh right, so we have a proper test coverage, let's get it back.

The patch itself looks good to me.

Do we want to update the statistics module to take advantage of this (dog-fooding) or is that not really an option?

Seems like a recipe for performance issues though. These tables get really big.

That sounds like a "needs review."

Also note the existence of #1446956: Remove the accesslog from statistics. It's possible we want to postpone this issue until something's decided over there.

I would personally vote to do the integration first, because we have another issue which describer which parts of drupal we want to replace: #1864980: [meta] Figure out how to integrate Views into core

Hm. but if the accesslog table goes away entirely, including all of the faculties of tracking hostname, locations, hits, etc... then we don't need any Views integration nor any default views for that functionality. Or do I misunderstand?

@webchick
Absolute! Maybe we should simply just integrate the node_counter table for now?

Yeah, that would be safer for now, I think. Would probably also help with Dries's performance/big table concern. We could file a postponed follow-up for the accesslog table, pending resolution of that issue.

Let's rerole after removing of accesslog.

Simple is good, Let's get it in!

Is there a follow-up issue that deletes the old/existing statistics module table in favor of a view? I can't seem to find it.

I'm confused about your last comment dries.

Didn't we killed the feature of the old/existing statistics module tables with the accesslog patch from above? #1446956: Remove the accesslog from statistics
Just checked and statistics module is just about count node views, but sure we could build a view for that.

Yes the listing is gone, this is just integration for the count statistics for which there's no list display in core at all.

Committed/pushed to 8.x.