Sort Install profiles on Site add form

I like this too, good job.

This patch adds a call to node_load, the performance implications of this should be investigated.

Thanks very much for the patch, I've applied the sorting part to 6.x-2.x, but I've not included the part that adds the short name to the list. Please open a separate issue for that, and we can discuss there, I think there's a small performance issue with doing the node load on each profile, and the site form is already super slow.

heh, can't you get the short_name from hosting_package_instances_load?

That way the performance issue can be handled within hostmaster rather than relying on the core of d6 to do something.

For example, I haven't profiled it but _hosting_package_instances_load() looks like it's screaming to be at least statically cached, if not persistently.

If it was persistently cached you could add all sorts of hostmaster-specific bits and pieces (like the short_name) to the UI without invoking a bunch of node_load()s - which are much slower than they should be in d6 without native, or even contrib, persistent caching of node objects :/

Would anyone be interesting in me opening a ticket for that in parallel to the issue for displaying the short_name, as it seems like in light of this discussion it may (perhaps after a little profiling) help get that nice UI improvement over the line?

@thedavidmeister please open such a ticket!

done - #1875440: static and persistent caching for _hosting_package_instances_load()