Drupal.org
Issues

Inspira Theme

Posted by kaasi on November 29, 2012 at 5:31pm
Project:Drupal.org Project applications
Component:theme
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

Inspira Theme is a beautiful Drupal 7 theme. As an adaptive theme it is designed to work well on desktop, tablet, and mobile devices.

Project page:
http://drupal.org/sandbox/kaasi/1817884

made a 7.x branch:
git clone --recursive --branch 7.x-1.x kaasi@git.drupal.org:sandbox/kaasi/1817884.git inspira

This theme is for the 7.x versions of drupal.

AttachmentSize
inspira.png752.63 KB
Login or register to post comments

Comments

#1

Posted by monymirza on November 30, 2012 at 11:26am
Priority:normal» critical
Status:needs review» needs work

Hi,

try to clear warnings and erros.
http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

You have also missed code standards. see here: http://drupal.org/coding-standards

#2

Posted by kaasi on December 3, 2012 at 6:29pm

Hi monymirza,

I fixed the errors,

Please Check: http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

Thank you very much.

#3

Posted by monymirza on December 4, 2012 at 5:24am

/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
28 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------

template.php
where it is $form['actions']['submit'] = array('#type' => 'image_button', '#src' => base_path() . path_to_theme() . '/css/images/search-button.png');

make proper like;

$form['actions']['submit'] = array(
  '#type' => 'image_button',
  '#src' => base_path() . path_to_theme() . '/css/images/search-button.png'
);

README.txt:
Add more description about your theme.

#4

Posted by monymirza on December 4, 2012 at 5:30am
Priority:critical» normal

#5

Posted by kaasi on December 5, 2012 at 4:48am

I have only one error but i don't know how to solve it.

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

Can you help me please

#6

Posted by monymirza on December 5, 2012 at 5:51am

Not sure but try this,

Remove line #4 & #7.

#7

Posted by kaasi on December 12, 2012 at 4:29am

I fixed it

Please Check http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

#8

Posted by monymirza on December 12, 2012 at 4:58am
Status:needs work» needs review

#9

Posted by cog-axis on December 18, 2012 at 1:36pm

Hi Kassi,
Please review your theme from coder module it gives errors. See attachment. Remaining I have installed your theme will post you more on this.

Good luck :-)

Thanks!

#10

Posted by cog-axis on December 18, 2012 at 1:36pm

Hi Kassi,
Please review your theme from coder module it gives errors. See attachment. Remaining I have installed your theme will post you more on this.

Good luck :-)

Thanks!

#11

Posted by cog-axis on December 18, 2012 at 1:40pm

Sorry about duplicate message. See attached image.

AttachmentSize
Inspira-theme.png 2.98 MB

#12

Posted by monymirza on December 19, 2012 at 7:08am
Status:needs review» needs work

#13

Posted by mayank-kamothi on March 5, 2013 at 6:57am

Hi,

Manual Review:
I have checked your theme and resize browser and found some issue ,I have attached screen-shot.

issue-1.png: Search button issue when resize browser
issue-2.png: When resize browser slider navigation not align proper and between "About Inspira" and naviagtion control have no space.look like both are joins.

Mayank Kamothi

AttachmentSize
issue-1.png 208.86 KB
issue-2.png 223.13 KB

#14

Posted by PA robot on May 14, 2013 at 10:25am
Status:needs work» closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.