Inspira Theme is a beautiful Drupal 7 theme. As an adaptive theme it is designed to work well on desktop, tablet, and mobile devices.

Project page:
http://drupal.org/sandbox/kaasi/1817884

made a 7.x branch:
git clone --recursive --branch 7.x-1.x kaasi@git.drupal.org:sandbox/kaasi/1817884.git inspira

This theme is for the 7.x versions of drupal.

CommentFileSizeAuthor
#13 issue-1.png208.86 KBmayank-kamothi
#13 issue-2.png223.13 KBmayank-kamothi
#11 Inspira-theme.png2.98 MBcog-axis
inspira.png752.63 KBisaakordonez

Comments

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Priority: Normal » Critical
Status: Needs review » Needs work

Hi,

try to clear warnings and erros.
http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

You have also missed code standards. see here: http://drupal.org/coding-standards

isaakordonez’s picture

isaakordonez commented

Hi monymirza,

I fixed the errors,

Please Check: http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

Thank you very much.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented 
/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
28 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------

template.php
where it is $form['actions']['submit'] = array('#type' => 'image_button', '#src' => base_path() . path_to_theme() . '/css/images/search-button.png');

make proper like;

$form['actions']['submit'] = array(
  '#type' => 'image_button', 
  '#src' => base_path() . path_to_theme() . '/css/images/search-button.png'
);

README.txt:
Add more description about your theme.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Priority: Critical » Normal
isaakordonez’s picture

isaakordonez commented

I have only one error but i don't know how to solve it.

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/template.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
8 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------

Can you help me please

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented

Not sure but try this,

Remove line #4 & #7.

isaakordonez’s picture

isaakordonez commented

I fixed it

Please Check http://ventral.org/pareview/httpgitdrupalorgsandboxkaasi1817884git

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs work » Needs review
cog-axis’s picture

cog-axis commented

Hi Kassi,
Please review your theme from coder module it gives errors. See attachment. Remaining I have installed your theme will post you more on this.

Good luck :-)

Thanks!

cog-axis’s picture

cog-axis commented

Hi Kassi,
Please review your theme from coder module it gives errors. See attachment. Remaining I have installed your theme will post you more on this.

Good luck :-)

Thanks!

cog-axis’s picture

cog-axis commented
StatusFileSize
new Inspira-theme.png2.98 MB

Sorry about duplicate message. See attached image.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work
mayank-kamothi’s picture

mayank-kamothi commented
StatusFileSize
new issue-2.png223.13 KB
new issue-1.png208.86 KB

Hi,

Manual Review:
I have checked your theme and resize browser and found some issue ,I have attached screen-shot.

issue-1.png: Search button issue when resize browser
issue-2.png: When resize browser slider navigation not align proper and between "About Inspira" and naviagtion control have no space.look like both are joins.

Mayank Kamothi

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.