Upgrade drush used for distro packaging with drush make

Crazy! I'd guess this may be a bug in how drush make handles libraries fetched via git, but haven't verified by testing locally.

I can confirm this issue, we ran across it in Commerce Kickstart, see #1873148: Libraries should be downloaded from zip files, not cloned from git.
All of our libraries had .git directories packaged, leading to issues when users tried to commit the packaged distro to a git repository of their own.

This has been fixed in Drush #1875510: Drush Make does not remove .git directories for core and libraries.

DamZ tells me this is the way to do it :)

(Or do I need to do that to the actual Drush issue?)

How does this actually get implemented? I'm looking at #1427752: Support drush make includes[] in drupal-org.make files and just not sure who is responsible for doing it? What happens after it gets RTBC?

Yeah, sorry. The problem is that d.o doesn't have a regular standard process for deploying changes. It happens ad hoc based on who has time to responsibly follow the deployment through completion (including being available to deal with anything that might go wrong) and what particular itches are being scratched at the moment. For example, most of the folks with the power to deploy changes like these (including myself) are busy working on the d.o D7 port. :/ Ultimately, we desperately need #1929526: Drupal.org Software Working Group Charter (DRAFT). Meanwhile, it'd be good to still be able to roll out bug fixes like this. I'd vastly prefer not to be a single point of failure, it happens a lot, and I'm trying to put my energy into making that not the case each time it crops up, instead of just doing all the work myself. But maybe there's no good solution here in the short term, and I'll just have to eat it and do this sometime soon this week. Stay tuned.

Thanks/sorry,
-Derek

At the moment, there hasn't been a drush release lately. Ideally, we want to upgrade to 5.9. (We can upgrade to -dev if a release isn't happening in a timely manner and we need the fixes.)

Thanks! There's lots of process stuff that has just happened because people make it happen in the community. Only so much time, and always so much to do.

5.9 is now out. We have 5.10.0 and 6.2.0 to choose from, https://github.com/drush-ops/drush/releases. I think we should upgrade to 5.10.0, incremental upgrades are less stressful.

Setting to major because we want to be in a good place to fix #2213315: Packaging loop more permanently.

The next steps are:

• Make a copy of /var/www/drupal.org/tools on devwww.
• Make upgrades to that codebase, keeping good notes in this issue.
• Test packaging a few distros on a dev site configured to use that tools directory. A release's packaged files on the dev site can be removed in the filesystem and re-added to trigger packaging. Check that all code paths of the drupalorg_drush work well.

Not ready for deployment. Needs testing first.

Seems like drumm is on this one.

Will need some help from Rudy first, building on #2310409: Upgrade to Drush 6 on buildvm.

We will want drush6 available on every box that has the drupalpackaging Puppet module. Likely as part of that module, keeping this Drush for packaging independently deployed from other Drush instances. Being able to have both in parallel will be a big help for testing.

drush (symlink to drush5) and drush6 are now installed concurrently on all hosts with drupalpackaging.

This can now proceed. On util and git7staging:

bash-3.2$ drush6 --version
 Drush Version   :  6.3.0

[drumm@git7staging ~]$ drush6 --version
 Drush Version   :  6.3.0

Next we need to test that these work reasonably well:

• verify-makefile, as called by drupalorg's project_verify_package/project_verify_package.pages.inc
• make and related code, as called by drupalorg's drupalorg_project/plugins/release_packager/DrupalorgProjectPackageReleaseDistro.class.php

I'm not actively working on this right now, so I won't assign it to myself yet. When deployment is scheduled, it will be announced with https://www.drupal.org/news/change-notifications-drupalorg.

I'm not incredibly familiar with Drush make upgrades. Is this change important enough to email all distribution maintainers about?

We do require that maintainers are subscribed to the maintainer news email list, so it would be okay to email important things.

This was done quite awhile ago

btch1:~$ php /var/www/drupal.org/tools/drush.phar --version
 Drush Version   :  8.1.12