Undefined property: stdClass::$payment_method in uc_credit_order [#1854596]

Posted by DamienMcKenna on November 30, 2012 at 4:01am

4 followers

Issue Summary

The following watchdog message is recorded when I load the checkout page:

Notice: Undefined property: stdClass::$payment_method in uc_credit_order() (line 307 of ubercart/payment/uc_credit/uc_credit.module).

Posted by DamienMcKenna on November 30, 2012 at 4:04am

Status:

active

» needs review

This patch just checks to see if the value exists before using it.

Attachment	Size	Status	Test result	Operations
ubercart-n1854596.patch	763 bytes	Idle	PASSED: [[SimpleTest]]: [MySQL] 2,117 pass(es).	View details

Posted by TR on November 30, 2012 at 4:50am

Priority:

normal

» minor

Can you copy what was done in 7.x-3.x, by using isset() instead of !empty() ?

Posted by DamienMcKenna on November 30, 2012 at 5:43am

Sure thing.

Attachment	Size	Status	Test result	Operations
ubercart-n1854596-3.patch	762 bytes	Idle	PASSED: [[SimpleTest]]: [MySQL] 2,113 pass(es).	View details

Posted by longwave on December 1, 2012 at 9:39am

Status:

needs review

» fixed

Committed.

Posted by System Message on December 15, 2012 at 9:40am

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.