Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
field_ui.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
30 Nov 2012 at 12:37 UTC
Updated:
29 Jul 2014 at 21:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yched commentedAgreed.
@sun even advocated for a render array.
Comment #2
swentel commentedtagging
Comment #3
swentel commentedLet's tackle this in #1982138: Clean out field_ui.admin.inc
Comment #4
swentel commentedComment #5
swentel commentedOk, nevermind, let's make sure the patches are reviewable. Moving to core queue
Comment #6
swentel commentedWhile, we're there, cleanup docs as well.
Comment #8
swentel commentedOf course you need to fix the tests too ...
Comment #9
yched commentedMinor:
The
<br />is not needed anymore ?Other than that, looks good to me :-)
Comment #10
swentel commentedOh sweet irony .. :)
Comment #11
yched commentedYay, thanks !
Comment #12
aspilicious commentedGreat!
Comment #13
alexpottLike this..
And do the same for the other similar cases...
Comment #14
swentel commentedDone
Comment #15
alexpottCommitted 30e1599 and pushed to 8.x. Thanks!
Comment #16
swentel commentedChange notice created at http://drupal.org/node/2003680
Comment #17
aspilicious commentedExcellent, we don't need more!
Comment #18
amateescu commentedReviewed and refined the change notice on irc, looks good to me now.