Notice: in views_timelinejs_plugin_style_timelinejs->render() (line 232 of /XXX/modules/contrib/views_timelinejs/views_timelinejs_plugin_style_timelinejs.inc).

Offending code:

          if (isset($this->options['timeline_config']['link_text_enabled'])) {
            $rows[$count][$target_field] .= theme('views_timelinejs_link_to_entity', array('uri' => $row->uri['path'], 'link_text' => t($link_text)));

A couple things here; the root problem is that the row did not have a URI; this speaks to the larger issue of requiring the media to be an image field, which is kind of odd as Timeline JS just takes a bare URL.

CommentFileSizeAuthor
#2 views_timelinejs-nouri-1855440-2.patch9.2 KBfluxsauce
#1 views_timelinejs-nouri-1855440-1.patch963 bytesfluxsauce

Comments

fluxsauce’s picture

fluxsauce commented
Status: Active » Needs review
StatusFileSize
new views_timelinejs-nouri-1855440-1.patch963 bytes
fluxsauce’s picture

fluxsauce commented
StatusFileSize
new views_timelinejs-nouri-1855440-2.patch9.2 KB

EDIT - ignore patch, re-rolling.

operinko’s picture

operinko commented
Status: Needs review » Fixed

The latest patch does not apply after applying the one from http://drupal.org/node/1855560.
As far as I can see, the only difference between this patch and that other patch is
&& isset($row->uri['path'])

I added that one, just to be on the safe side.

fluxsauce’s picture

fluxsauce commented

I added that one, just to be on the safe side.

Cool, that sorts the issue. As I was talking through #1860744: Optional Link text always displayed with imclean I gathered that, but wasn't in a position to say duplicate so I just gave him good advice :-) The && isset($row->uri['path']) addresses the notice.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.