Title says it all, it seems all other core modules use the structure of tests/modules/TEST_MODULE for their tests modules, we should move this for user too.

I'm in the process of moving around alot of views tests in #1855228: Move Views core module tests to their respective modules, and as this is much easier, postponing on that issue for now. Then we can just move everything in one go.

CommentFileSizeAuthor
#10 1855792-10.patch459 bytesdamiankloip
#1 1855792.patch6.51 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Postponed » Needs review
StatusFileSize
new 1855792.patch6.51 KB

This patch does nothing but move the modules into a modules/ dir and place the user_form_test files into a folder.

Status: Needs review » Needs work

The last submitted patch, 1855792.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

#1: 1855792.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1855792.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

#1: 1855792.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1855792.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review

#1: 1855792.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Epic retest of death!

+1 for consistency!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed/pushed to 8.x.

damiankloip’s picture

damiankloip commented
Status: Fixed » Needs review
StatusFileSize
new 1855792-10.patch459 bytes

Oh, not sure how that happened, there was the test_views_handler_field_role test view in the old location. Maybe something got committed with this in the mean time?

This fixes that test for me.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Looks like catch committed this as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.