Allows setting alternative site name for Branding region.

drupal.org/sandbox/pingwin4eg/1856160
git clone --recursive --branch 7.x-1.x pingwin4eg@git.drupal.org:sandbox/pingwin4eg/1856160.git branding_site_name
core = 7.x

CommentFileSizeAuthor
#1 code-review.txt1.24 KBanwar_max

Comments

anwar_max’s picture

anwar_max
Primary language English
commented
Status: Needs review » Needs work
StatusFileSize
new code-review.txt1.24 KB

Automated Review:

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Result of automated code review

Manual Review:

Everything looks good to me but you cannot get GIT vetted permissions with this module it is a small module and have very less code.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue tags: +PAreview: single application approval

@anwar_max: short modules are totally ok, we simply promote them manually instead of giving the git vetted user role away. Please use the "PAReview: Single project promote" tag for such applications.

@pingwin4eg: We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

anwar_max’s picture

anwar_max
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Everything looks good to me except minor issues mentioned in the automated review. I think we can promote this project as a full project.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Status: Reviewed & tested by the community » Needs work

Thank you guys for reviews!
By the way I got an idea of new feature to this project. And I have a question. Will I be able to commit changes to this project (the full its version) if I don't get the git vetted role? If no then don't hurry with it and please point me what status of this issue i should set.

P.S.: don't have much time to help reviewing other projects now, but i'm on that way.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)