Closed (fixed)
Project:
Gallery formatter
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2012 at 22:23 UTC
Updated:
2 Jan 2013 at 01:01 UTC
When a image field has multiple values, the default behavior is supposed to be setting their TITLE as "[node title] image 0...n".
However in my case, titles are always "image 0...n" without a node title.
Looking into the code, I found this (galleryformatter.module l. 276)
if(strpos($entity->title, '<') !== FALSE) {
$item['title'] = strip_tags($entity->title);
}
Shouldn't it be like this though?
if(strpos($entity->title, '<') !== FALSE) {
$item['title'] = strip_tags($entity->title);
} else
$item['title'] = $entity->title;
This fixed the issue for me.
This is my first time posting an issue, I apologise in advance if I did anything incorrectly.
Comments
Comment #1
manuel garcia commentedYou are totally right. I've committed the fix giving you authorship of the patch. So you should see one commit to this project on your user profile page =)
Thank you!
Comment #2
kytom commentedWow! I feel honoured, I wouldn't know how to pull off a commit myself... :) Thank you!