Hi - Stephanie again.

I have some FAQs to which I've attached images (e.g. explanatory screenshots) using image_attach. This works with other content types but doesn't work with FAQs. I can edit the FAQ and attach the image and it displays at that point, but within the context of the FAQ page, there are no images. I like using the "click to openhide answer under question" layout.

Am I missing something, or does the FAQ module not support images? This could be really slick.

CommentFileSizeAuthor
#5 faq_185680.patch7.05 KBnancydru

Comments

stella’s picture

Assigned: Unassigned » stella
Status: Active » Postponed

Postponed - waiting for feedback on #188543.

Images added in the normal way (i.e. <img> tags) should appear without any changes I believe.

Cheers,
Stella

StephanieM’s picture

Hi Stella:

As a workaround this is great, but it requires the user to use (and know how to use!) Full HTML input format, plus the complete path to the image involved. If those have been uploaded with the Image module they're usually buried in the files directory.

If you find a way to get it working I'd love to see it.

Cheers!

Stephanie

nancydru’s picture

...user to use (and know how to use!) Full HTML input format...

Actually no it doesn't. You can add the IMG tag to your list of allowed tags in the Filtered HTML settings.

nancydru’s picture

Hmm, if I select a teaser display, such as "node/type/faq", that FAQ doesn't intercept, the image shows up.

@Stephanie: do you want it showing on the questions list page, or only if the question is selected for viewing?

nancydru’s picture

Assigned: stella » nancydru
Status: Postponed » Needs review
StatusFileSize
new7.05 KB

This patch is based on the March 2nd 5.x-2.x-dev version. It turns out it was harder finding all the different formats than fixing the problem. It would have happened automatically if we could have used node_view, but we couldn't, so fooled image_attach into thinking we had. Please give it a try and report the results.

I will leave this to Stella, probably, to actually commit and port to 6.x.

nancydru’s picture

Have you tried this yet?

stella’s picture

Status: Needs review » Patch (to be ported)

Hi Nancy,

I've committed your patch to the 5.x branch. However, it's not going to be easy to port to 6.x as the theming stuff has changed in D6 - most of it is now done in template files. I should have something similar (functionality wise at least) later in the week for D6. Then we can look at what would be involved in using node_view() instead as you mentioned in #214284: Display FAQ node links on the main FAQ page, will continue that discussion there.

Stephanie - this feature show now be implemented in D5 and will be available in the next release.

Cheers,
Stella

nancydru’s picture

I understand - that's one reason why I didn't do a 6.x version.

stella’s picture

Status: Patch (to be ported) » Fixed

I've now committed this to the 6.x branch and will be included in the next release.

Cheers,
Stella

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

stella’s picture

Released in faq versions 5.x-2.10 and 6.x-1.6.

Cheers,
Stella

markusd1984’s picture

Issue summary: View changes

When loading many FAQs on the same page that contain images it slows down the loading dramatically.

Any advice or best practice you can share to avoid or improve that?

I know image sizes should be compressed at file level beforehand to avoid unnecessary large resolution and file sizes.
Also thinking of if there is a way to implement placeholders to load first and possibly caching?