Earlier versions of the codebase created records for entities that are now no longer supported, e.g. comment, file (when using file_entity), mailchimp_list, profile2_type, taxonomy_vocabulary, and possibly others. Compile an authoritative list of these entity types and then build an update script to purge the {metatag} table of matching records.

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new822 bytes

Rather than manually tracking a manual list of unsupported entities, just using entity_get_info() should be enough.

damienmckenna’s picture

Common entities that could be safely manually purged:

  • comment
  • mailchimp_list
  • profile2_type
  • redirect
  • file
  • taxonomy_vocabulary
  • wysiwyg_profile
  • rules_config
  • menu_link
damienmckenna’s picture

StatusFileSize
new1.05 KB

A patch that just purges the items listed in #2 above.

damienmckenna’s picture

Status: Needs review » Fixed

Committed.

damienmckenna’s picture

Status: Fixed » Postponed
Issue tags: +D7 stable release blocker

Marking this as Postponed as I'll have to come back to it later for a final cleanup.

dave reid’s picture

Meta tags are perfectly valid with file entities when used with File entity module. Why should those be removed?

damienmckenna’s picture

Status: Postponed » Needs review
StatusFileSize
new326 bytes

Because the file entity configuration doesn't have 'metatags' = TRUE assigned. I've added #1857334: Enable Metatag support for File entity? to make a decision and, for now, will remove 'file' records from the to-purge list.

damienmckenna’s picture

Status: Needs review » Postponed

I've committed the patch from #7 and putting this back on the Postponed stack to be dealt with later.

damienmckenna’s picture

Status: Postponed » Needs review
StatusFileSize
new744 bytes

Better reporting for data deletion.

damienmckenna’s picture

Status: Needs review » Postponed

Committed.

damienmckenna’s picture

StatusFileSize
new333 bytes

One more tweak - get rid of the profile2 records.

damienmckenna’s picture

I've committed the patch from 11, leaving it as Postponed for now.

damienmckenna’s picture

No need to tag something as being a release blocker if I'm postponing it.

damienmckenna’s picture

Issue summary: View changes
Status: Postponed » Fixed

Honestly I think this is good enough for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.