multivalued fields should be supported somehow. I'm not even sure how it handles it now

CommentFileSizeAuthor
#4 efq_extra_field-1857240.patch2.61 KBjonhattan
#3 efq_extra_fields_multivalued_wrong.png74.79 KBjonhattan
#3 efq_extra_fields_multivalued_right.png58.29 KBjonhattan
#3 efq_extra_field-1857240.patch2.61 KBjonhattan

Comments

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Fixed

Added support for that in http://drupalcode.org/project/efq_extra_field.git/commit/438ef105b272c7c...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new efq_extra_field-1857240.patch2.61 KB
new efq_extra_fields_multivalued_right.png58.29 KB
new efq_extra_fields_multivalued_wrong.png74.79 KB

When there're more than two values, it starts nesting the results.

The provided patch fixes it, by creating a plain array as in:

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new efq_extra_field-1857240.patch2.61 KB 
+++ b/efq_extra_field.module
@@ -86,23 +86,31 @@ class EntityFieldQueryExtraFields extends EntityFieldQuery {
+              $value = $previous_entity->extraFields->{$id};
+              $value[] = $entity->extraFields->{$id};
+              $entity->extraFields->{$id} = $value;

Reworked this lines.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

aromka’s picture

aromka commented

Works great! Thanks!

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Committed

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.