We should use viewsHstFilter instead of views_hst_filter.

CommentFileSizeAuthor
#1 views_hst_filter-camelcase_namespace-1858132-1.patch419 bytesyannickoo

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new views_hst_filter-camelcase_namespace-1858132-1.patch419 bytes
ser_house’s picture

ser_house commented
Status: Needs review » Fixed

Applying :)

P.S.: I wrote wrong issue number and I don't know how remove this commit :(

Sk8erPeter’s picture

Sk8erPeter commented

btw. why is
if ('views_hst_filter_ajax_callback' == Drupal.ajax[ajaxObject].callback)
better than
if (Drupal.ajax[ajaxObject].callback == 'views_hst_filter_ajax_callback')
from a readability aspect? To me, the second one is more readable, when I take a quick look at it.

ser_house’s picture

ser_house commented

@Sk8erPeter

'views_hst_filter_ajax_callback' in that case is constant, I usually place the constant to left side.

Code Complete :)

Sk8erPeter’s picture

Sk8erPeter commented

I know what this is. I accept it, it's just a coding habit, and you don't need to refer to any kind of books to confirm your own habit (or refer to others' coding habits) - it's just a matter of preferences. I don't like to accept one book as THE book that tells THE truth.
"so many men so many minds"

yannickoo’s picture

yannickoo
Location Berlin
commented

The only different is that you would get an error when you try to assign a variable to the string but this is not the case so we could do it like usual. BTW this is called yoda condition. I created a follow up issue #1858224: Revert yoda condition

ser_house’s picture

ser_house commented

@Sk8erPeter

You asked I answered.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1832320)