Admin Theme: Wrong theme used on 403 pages

Right. So let me see if I have this correct.

* 3 domains. Each has a specific theme and specific admin theme.
* User tries to access /admin. Gets 403 page.
* 403 page renders in the admin theme of the current site.

Is that last part correct? Or does it render in the admin theme of the default site?

In my test. The 403 returned the theme for the default domain, even though I was on a different domain.

Here's the problem code, from domain_theme_custom_theme():

  // Check for a custom admin theme.
  if (isset($conf['admin_theme']) && path_is_admin(current_path())) {
    $theme = domain_theme_lookup($_domain['domain_id'], $conf['admin_theme']);
  }
  else {
    // Assign the theme selected, based on the active domain.
    $theme = domain_theme_lookup($_domain['domain_id']);
  }

Let's try reversing those lines.

This should work.

The $_GET['q'] is not required.

Problem is, we've seen misbehavior using menu_get_item() here before, especially when AJAX is involved (as in Features admin).

Right. As I understand it, the 403 should not render in the admin theme. It should render in the assigned domain theme.

The problem with AJAX and menu_get_item() is that the second page request (the AJAX call) can reset the menu item and throw off the expected behavior. I have seen that with Features and Display Suite admin pages.

If the Features admin works with this code, then it should be ready to go.

So this causes Features to display in the wrong theme, due to the AJAX.

See #1718968: Domain Conf administrative theme <=> Domain Theme theme settings for where this code was introduced.
See #1419090: Domain theme, admin theme broken broken for certain paths in Features module for the Features issue.

It is difficult, because of the execution order of the code and the frustrations of the menu system, we cannot check for menu access without invoking menu_get_item(), and invoking that function breaks certain admin paths.

I have not found a way to fix your issue without re-breaking #1419090: Domain theme, admin theme broken broken for certain paths in Features module or doing handstands to load the menu data without calling menu_get_item().

At this point in the call stack, even drupal_get_http_headers() returns empty, because headers haven't been set yet.

Step away for a bit, and clarity appears ;-).

This would, at least, work for anon users.

I don't follow point 3 above.

The issue is that we can't run a check for menu item access without breaking certain theme functions. That's what the old Features issue is about. The patch in #11 tries to fix that, and is perhaps correct. If you can view admin theme and the 403 is an admin page, using the admin theme seems appropriate.

There is also a permission for 'view administration pages', and we could check that instead.

The patch mimics what core does. If you can access the admin theme in core, your 403 is delivered in the admin theme.

/**
 * Implements hook_custom_theme().
 */
function system_custom_theme() {
  if (user_access('view the administration theme') && path_is_admin(current_path())) {
    return variable_get('admin_theme');
  }
}

At the moment, it's because we don't check that access. This patch fixes that.

Committed!

   4ee008b..93e7b19  7.x-3.x -> 7.x-3.x