When changing a project via a comment, the change is not shown during preview. The change is reflected in the breadcrumb (surprising to me) but not in the table of changes. Once submitted, the project change does appear. Priority=minor.

Great job, everyone. Really nicely done.

CommentFileSizeAuthor
#7 pi_js.patch5.22 KBhunmonk

Comments

dww’s picture

Confirmed. Agree this should be fixed. While reproducing this, I noticed another bug: http://drupal.org/node/185875 -- it's possible the cause is related to this, but I think that's actually a separate bug so I submitted a new issue for it.

dww’s picture

Category: feature » bug
Priority: Minor » Normal

Oh, and since this is a regression from pre-IFAC, and useful functionality, I'm changing the category and priority of this issue...

hunmonk’s picture

Status: Active » Postponed (maintainer needs more info)

i am unable to reproduce this bug, both on a local dev install, and on project.drupal.org -- the metadata table is displaying just fine in previews for me. can you guys include some exact steps to reproduce??

dww’s picture

Status: Postponed (maintainer needs more info) » Active

@hunmonk: you have to change the issue's project, let the JS fire, and try to preview... for example:

- Start at http://project.drupal.org/node/42232
- Down under "edit issue settings" in the "project info" fieldset, change "Project" to "Project issue tracking"
- Watch JS update version and components lists (and note that "5.x-1.x-dev" is selected as the version).
- Press preview once and witness http://drupal.org/node/185875
- Select "5.x-1.x-dev" again as the version and press preview once more
- Witness that the version is displayed in the comment preview metadata table, but not the change from "project" to "project issue tracking".

(please don't actually post your comment, so that others can use these identical instructions to keep reproducing it until the bug is solved).

hunmonk’s picture

Status: Active » Closed (duplicate)

this is a problem with the project_issue js, not the metadata previews of comments.

duplicate of http://drupal.org/node/185875

dww’s picture

Title: Project change missing from Preview » Changing project in an issue with JS is broken
Status: Closed (duplicate) » Active

This is the earlier issue, and describes both of the symptoms, let's solve it here.

hunmonk’s picture

Status: Active » Needs review
StatusFileSize
new5.22 KB

ah, ok -- now i see. this does look like the correct place to handle this.

this is a result of the mess of collisions. not node collisions as usual, but form element collisions. we had to tree the project_info fieldset, b/c pid was colliding w/ comment module's pid. this was never properly fixed in the corresponding js.

so attached does the following:

  1. tree's the js form elements the same way that the original form does.
  2. gets the id naming consistent for those form elements between the original display and the js selectors.
  3. fixes another small metadata bug when changing the project -- we have to check against the copy of the original issue to build the metadata table, not the adjusted issue due to the project change.
dww’s picture

Status: Needs review » Reviewed & tested by the community

You explaination makes sense, code looks fine, and the patch works correctly via local testing. Ship it! ;) Thanks.

hunmonk’s picture

Status: Reviewed & tested by the community » Fixed

fixed in HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.