There were a few improvements we made to the WYSIWYG + WYSIWYG Filter to fully support HTML5.

I wanted to keep you guys in the loop in case any of this was of interest to you or recommendations on anything we are doing wrong. :)

The link to our updated module based off of panopoly_wysiwyg is at: https://github.com/wet-boew/wet-boew-drupal/tree/master/modules/custom/w...

Some of the implemented fixes:

1) Upgraded to TinyMCE 3.5.8 to bypass data attribute bug and a few other minor issues

2) Improved and added various patches for wysiwyg_filter, image_resize_filter, and linkit (for multilingual, there are 2 other patches need to review for i18n)

3) Change WYSIWYG.module to support HTML5: https://github.com/wet-boew/wet-boew-drupal/blob/master/modules/custom/w...

4) Extended valid_elements to allow only valid HTML5: https://github.com/wet-boew/wet-boew-drupal/blob/master/modules/custom/w...

5) Allowed all classes and ids through by default: https://github.com/wet-boew/wet-boew-drupal/blob/master/modules/custom/w...

CommentFileSizeAuthor
#2 1858658-wysiwyg-updates.patch4.11 KBbeeradb

Comments

sylus’s picture

sylus commented
Issue summary: View changes

Mod

sylus’s picture

sylus commented
Issue summary: View changes

Mod

populist’s picture

populist commented
Assigned: Unassigned » beeradb

Thanks for sharing. Let's get a patch rolling so assigning to beeradb. My guess is we are going to want to implement (1), (2) and (5) completely. (3) and (4) will need to be considered so we don't break legacy handling.

beeradb’s picture

beeradb commented
StatusFileSize
new 1858658-wysiwyg-updates.patch4.11 KB

Here's a start to this. This does #1 and #5. I'm hesitant to roll with #2 because it moves us to 3 different dev versions of modules, which is problematic as we're trying to move to a stable 1.0 release of Panopoly. I think the strat for #2 should be to review the patches it incorporates and try to get those into stable releases.

The cirkuit tinymce patch still applies cleanly to 3.5.8.

populist’s picture

populist commented
Status: Active » Postponed

I am going to postpone this since #1965864: Support CKEditor in Panopoly might shake things up.

populist’s picture

populist commented
Issue summary: View changes

Mod

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Component: Code » Admin
Issue summary: View changes
Status: Postponed » Needs review

Re-opening. I've postponed #1965864: Support CKEditor in Panopoly, so we shouldn't be delaying anything on that one!