When changing the widget to "Media Multiselect", the "manage image crops" link, which is provided by Epsa Crop module, doesn't appear.

BEFORE:
http://i.imgur.com/xWenO.png

AFTER:
http://i.imgur.com/ARAKx.png

Can you provide a little support for that?
Thanks in advance!

CommentFileSizeAuthor
#2 media_multiselect-1859990-default_media_element_info_didnt_get_applied-2.patch779 bytesfangel

Comments

Sk8erPeter’s picture

Sk8erPeter commented
Title: Epsa Crop module's "Manage image crops" link doesn't get displayed when switching to Media Multiselect widget » EPSA Crop module's "Manage image crops" link doesn't get displayed when switching to Media Multiselect widget

I don't know whether it helps you or not, but here you can see that a process callback is added in an implementation of hook_element_info_alter():

/**
 * Implements hook_element_info_alter.
 * 
 * @access public
 * @param array &$type
 * @return void
 */
function epsacrop_element_info_alter(&$type) {
  $type['managed_file']['#process'][] = 'epsacrop_element_process';
  if (module_exists('media')) {
    $type['media']['#process'][] = 'epsacrop_element_process';
  }
}

and in epsacrop_element_process(), the link is getting added:

  if ($element['#type'] == 'media') {
    //for media, need to include the media elements even if the file is not defined, because it's not defined when file initially selected
    $element['#attached']['js'][] = array('type' => 'setting', 'data' => array( 'epsacrop_dialog' => array($element['#id'] => $setting)));
    $element['#attached']['js'][] = drupal_get_path('module', 'epsacrop') . '/js/epsacrop-media.js';
    $element['epsacrop'] = array(
      '#type' => 'link',
      '#href' => '',
      '#title' => t('Manage image crops'),
      '#attributes' => array('class' => array('button', 'manage-crop')),
      '#options' => array('fragment' => FALSE, 'external' => TRUE),
      '#weight' => 0,
    );
  }
  else if (isset($setting['fid'])) {
    $markup = "[<a href=\"javascript:Drupal.EPSACrop.dialog('" . $setting['entity_type'] . "', '" . $setting['field_name'] . "', '" . $setting['bundle'] . "', '" . $setting['fid'] . "', '" . $setting['url'] . "', [" . $setting['size'][0] . "," . $setting['size'][1] . "]);\">" . t("manage image crops") . "</a>]";
    $element['epsacrop'] = array(
      '#type' => 'markup',
      '#markup' => $markup
    );
  }

Does it help you telling why EPSA Crop links don't get added?
Thanks!

fangel’s picture

fangel commented
Status: Active » Needs review
StatusFileSize
new media_multiselect-1859990-default_media_element_info_didnt_get_applied-2.patch779 bytes

Sorry for the very long delay. Been busy with work and school.

Here's a patch that changes the processing of #media-elements to retain any information from element_info, so any hook_element_info_alter() changes should be kept now.
I've verified it worked with EPSA crop (it took me a while to figure out how to configure EPSA crop to get it to even attempt to add the links to the widgets)

Please test and see if it works for you too...

Sk8erPeter’s picture

Sk8erPeter commented
Status: Needs review » Reviewed & tested by the community

Perfect!! Thank you very much, I've just tested it (cropping, adding some new files, cropping again, saving, checking the results), and it works fine! :)
Marking it as RTBC. Keep up the good work! ;)

fangel’s picture

fangel commented
Status: Reviewed & tested by the community » Fixed

Thanks for checking. I've committed the patch. Closing the issue.

Sk8erPeter’s picture

Sk8erPeter commented

Cool, thanks fangel! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

egarias’s picture

egarias commented

Tried, but not working for me, I am also using the lates dev of manual crop
Image is here http://markup.io/v/9de1hmhk4982
any help pease?

egarias’s picture

egarias commented
Status: Closed (fixed) » Active

Mark open?

fangel’s picture

fangel commented

Image isn't working. Try to reproduce on a clean install with -dev versions of Manual Crop, Multi-select and all necessary dependencies. If it still fails, write down all modules you have, any and all error-messages you can find, what you expected to happen and what happened.

In general, any bug reports should contains enough information that who ever needs to look into it, can reproduce it. Without being able to reproduce an error, it's likely never going to be fixed...

egarias’s picture

egarias commented

Ok, sorry, ill do the report, meantime, the image is showing when you scroll down a little.

egarias’s picture

egarias commented

Trying to use-it in another site and same result.

Manual crop is visible when adding new media but not when editing existing uploaded media.
Modules:
@font-your-face
7.x-2.7
Database search
7.x-1.0-beta4
Search API
7.x-1.4
Search facets
7.x-1.4
Search pages
7.x-1.0-beta2
Search sorts
7.x-1.4
Entity Reference
7.x-1.0
Fieldgroup
7.x-1.1
Geofield
7.x-1.1
Link
7.x-1.1
CCK
7.x-2.x-dev
Devel
7.x-1.3
Google Analytics
7.x-1.3
Date
7.x-2.6
Webform
7.x-3.18
Manual Crop
7.x-1.4+31-dev
Active Tags
7.x-2.x-dev
jQuery Update
7.x-2.3
Wysiwyg
7.x-2.2
Chaos tools
7.x-1.2
File entity
7.x-2.0-unstable7
Media
7.x-2.0-unstable7

Media and Plupload connector
Media Multiselect
Media: Vimeo
7.x-2.x-dev
Media: YouTube
7.x-2.0-rc2
Plupload integration module
7.x-1.1
Meta tags
7.x-1.0-beta5
Localization client
7.x-1.2
Nodequeue
7.x-2.0-beta1
OpenLayers
7.x-2.0-beta3
Background Batch
7.x-1.14
Background Process
7.x-1.14
Colorbox
7.x-1.5
Entity API
7.x-1.0
Geofield Map
7.x-1.1
geoPHP
7.x-1.7
Google Admanager
7.x-2.3
Libraries
7.x-1.0
Media Colorbox
7.x-1.0-rc3
Media Crop
7.x-1.4
Multiple forms
7.x-1.0
Pathauto
7.x-1.2
Progress
7.x-1.4
Queue UI
7.x-1.x-dev
SASS / SCSS
7.x-2.0
Token
7.x-1.5
Transliteration
7.x-3.1
Ultimate Cron
7.x-1.8
Ultimate Cron Queue Scaler
7.x-1.0
Panels
7.x-3.3
Global Redirect
7.x-1.5
Boost
7.x-1.0-beta2
CSS Embedded Images
7.x-1.2
HTTP Parallel Request Library
7.x-1.10
Facet API
7.x-1.2
Page Title
7.x-2.7
Taxonomy menu
7.x-1.4
Views
7.x-3.5
XML sitemap
7.x-2.0-rc2

fangel’s picture

fangel commented

Try with a minimal install (meaning, clean install of drupal, with only media, multiselect and manual crop + dependencies), and see if you have issues there. If everything works with a minimum amount of modules, try adding modules one at a time, so we can figure out what breaks it..

fangel’s picture

fangel commented
Status: Active » Postponed (maintainer needs more info)

Is this still an issue for people?

Sk8erPeter’s picture

Sk8erPeter commented

@fangel: I'm still using the up-to-date versions of Media Multiselect + EPSA Crop (and Drupal 7.23) without any problem, so I think without any additional information, this issue could be closed as "fixed" again.

fangel’s picture

fangel commented
Status: Postponed (maintainer needs more info) » Fixed

Okay. Closing again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.