Currently "undefined index" errors are produced if not using an option end date. This fixes it.

CommentFileSizeAuthor
views_timlinejs-optional_enddate.patch5.66 KBimclean

Comments

fluxsauce’s picture

fluxsauce commented
Title: Handle option end dates correctly » Handle optional end dates correctly

Diff looks good, will fully exercise Monday.

Also, just from a refactoring point of view (out of scope for this issue), "value" and "value2" are dodgy names and should be something cleaner.

operinko’s picture

operinko commented
Status: Needs review » Fixed

True, those "value" and "value2" return variables *could* be changed into something more sensible, but I ended up using those due to the fact that the start and end values are named in that same manner in Date module as well.

Applied your patch, attributed the commit to you.
Thank you for these, I've been quite busy with another project as of late and this has sadly started lagging behind.

imclean’s picture

imclean commented

Except I submitted the patch! :-)

operinko’s picture

operinko commented

Oh crap :/
So you did, sorry :(

I'll see if I can fix it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.