Salsa_profile.module calls country_get_list() from locale, but locale is not enabled in D7's default install profile and it's not listed as a dependency in salsa_profile.info. I'll be posting a patch soon.

CommentFileSizeAuthor
#7 salsa_entity-salsa_profile_fix_locale_dependency-1861202-1.patch323 bytesjohnshortess
#1 salsa_entity-salsa_profile_fix_locale_dependency-1861202-1.patch426 bytesjohnshortess

Comments

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented
Status: Active » Needs review
StatusFileSize
new salsa_entity-salsa_profile_fix_locale_dependency-1861202-1.patch426 bytes

Here's a patch adding dependencies[] = locale to salsa_profile.info.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Active

Hey, you're alive! ;)

Yep, we overlooked that.

Instead of enforcing the dependency, we could also make the feature optional. Not sure what we should be doing in that case then. Maybe just display it as a textfield, but the problem there is that it then only accepts language codes, AFAIK.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Crosspost.

Status: Needs review » Needs work

The last submitted patch, salsa_entity-salsa_profile_fix_locale_dependency-1861202-1.patch, failed testing.

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented

Yes, I am alive! It's been a really crazy year. But I'm finally focusing on Salsa again -- I really like what I see in salsa_entity so far! And I'm hoping to give salsa_api some long overdue attention in the next couple of weeks, too.

Oops, testbot didn't like my patch -- I'll fix and resubmit. That will eliminate the error in the near-term, if you think changing the module's behavior and making the feature optional is a better long-term solution.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Ah, the problem with your patch is that you patched against the downloaded dev snapshot. That contains some additional build information below that you can see in your patch but it doesn't exist in the git checkout.

Don't worry, I'll be able to apply it.

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented
Status: Needs work » Needs review
StatusFileSize
new salsa_entity-salsa_profile_fix_locale_dependency-1861202-1.patch323 bytes

Okay, let's try this again. Was in the wrong repo. Not enough caffeine this morning...

johnshortess’s picture

johnshortess
he/him
Primary language English
Location Fairfax, Virginia, USA
commented

Crosspost. Again!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.