Implement hook_requirements()

We did think about this and didn't implement anything yet. The entire site does not need to be running HTTPS to use the Salesforce module, which the patch implies. It only needs to support HTTPS. My thought is to do some type of HTTPS check on the authorization page (and only there) and display appropriate messaging if it's not using HTTPS.

I also don't think we should throw a requirements error if Salesforce isn't authorized yet. Maybe a notice/warning?

New notifications attached:

Reports page:

Authorization page:

Patch attached adds these.

#4 didn't apply for me.
Applied manually and looks RTBC to me.

re-roll attached

Just something to add to the mix: I would prefer we NOT require HTTPS. Of course, I understand that HTTPS is technically required for the callback URL, but there is an easy workaround that I use for my development sites. Even though they don't support HTTPS, I list the callback URL as HTTPS anyway in Salesforce. When Salesforce tries to do the callback, I get the expected error. in my browser All I need to do is change the URL in the browser from https://... to http://... leaving everything else the same. The authorization token gets stored, and everything works just fine.

Clearly not something you want to do in production, but very handy for development. If we require HTTPS, then my trick will no longer work. :-(

Of course, I don't expect the project not to do something simply for my convenience. Just wanted to bring it up as food for thought.

@dbcollies: since this is a runtime requirement, it shouldn't prevent you from installing the module and using your workaround. Can you try the patch and confirm?