Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2012 at 04:13 UTC
Updated:
24 Mar 2013 at 17:42 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidWhat are you using to display meta tags with your Views?
Comment #2
aidanlis commentedWhat do you mean? I want metatags to use the global settings ...
Comment #3
damienmckenna@aidanlis: Do you mean that you're expecting the global meta tags to display on Views pages? Are they custom Views pages or are they entity pages being displayed using Views, e.g. taxonomy term pages?
Comment #4
aidanlis commentedThey are custom views pages, and yes it'd be great if the defaults carried through. I see there's work going on in #1804356: Views integration: option to add meta tags within the Views UI which would make this request redundant, so happy for you to mark as duplicate if that's the way forward.
Comment #5
torrance123 commentedThat was my expectation too — I expected the global defaults to work on all pages unless a more specific metatag configuration existed (eg. for node pages, user pages, etc.).
Are there any foreseeable issues with switching to this behaviour?
Comment #6
torrance123 commentedThis is one possible method to ensure all pages have, at a minimum, the global metatags set:
Edit: Fixed the patch snippet
Comment #7
damienmckennaThis version is a little cleaner - it only loads the meta tags if nothing was found already. I've tested it with metatag_context and the context-provided tags still load correctly, so I think it'll be fine.
Comment #8
torrance123 commentedGreat, I've patched our version of Metatags with the patch in comment 7, and all works as expected for us.
Comment #9
damienmckennaUpdating the title to better describe the change being made.
Comment #10
damienmckennaBecause this is potentially a performance drain on pages that may not need it, I've added a variable to control it and documented the new variable in the Fine Tuning section of the README.txt file.
Comment #11
damienmckennaARGH. I didn't output the results of "git diff", I output the results of "git status", and I've since reverted the changes.
Comment #12
damienmckennaRe-recreated the functionality and update to the README.txt file. Also, argh.
Comment #13
damienmckennaComment #14
damienmckennaCommitted.
Comment #15
damienmckennaNow that Metatag v7.x-1.0-beta5 is out am closing this to keep the issue queue clean.