This function menu_trail_by_path_page_delivery_callback_alter() does not return proper language options.

Hello developers and Drupal users,

I've come across an odd issue relating to Multi-lingual site configurations and this module in particular. Though it's output should be correct, for some strange reason, with the way my site is configured, the proper "path" link title and menu trail are not being selected.

Let me demonstrate via a dd() output.

In the case of my site, the following path https://achatsetventes.gc.ca/politiques-et-lignes-directrices/Archives-du-Guide-des-approvisonnements/Guide-des-approvisionnements-Version-2012-01 (don't go here, the url won't validate for you right now) when checking the _menu_trail_by_path_get_parent_candidates(drupal_get_path_alias()) we get the following return:

PARENT: Array
(
    [0] => node/8310
    [1] => node/8278
)

RECORD: Array
(
    [menu_name] => navigation
    [link_path] => node/8310
    [link_title] => Supply Manual Archive
    [depth] => 1
    [mlid] => 2875
)

RECORD: Array
(
    [menu_name] => navigation
    [link_path] => node/8310
    [link_title] => Archives du Guide des approvisonnements
    [depth] => 1
    [mlid] => 2880
)

What we see here, is in fact a doubling up of possibilities for the node/8310 menu trail. The problem is the breadcrumb is returning the following:

TPSGC >> achatsetventes.gc.ca >> Politiques et lignes directrices >> Supply Manual Archive >> Guide des approvisionnements : Version 2012-01

The problem here is the english "Supply Manual Archive" when it should actually read the french title "Archives du Guide des approvisonnements"

My thought is as follows:

Would it not be wiser to simply use the "language" option of the menu as opposed to trying to let the function _i18n_menu_link_title((array)$record, $language->language) do the trick? This seems to fail as it only takes the first option and ignores the second, meaningful choice?

I propose the following:

  $results = db_select('menu_links','ml')
    ->fields('ml',array('menu_name','link_path','link_title','depth','mlid','language'))
    ->condition('link_path', $parent_candidates, 'IN')
    ->condition('language', $language->language, '=')
    ->execute();

and removing

    // Get the Link Title if it can be found in a menu item
    if ($record->link_title && !isset($matched_link_titles[$record->link_path])) {
      $matched_link_titles[$record->link_path] = $record->link_title;
      /*
      if (module_exists('i18n_menu')) {
        $matched_link_titles[$record->link_path] = _i18n_menu_link_title((array)$record, $language->language);
      }
      */
    }

We no longer need to test for the i18n module and we keep the mechanism simply at the db_select level.

If need be, I can roll up a patch. But, I'd like to get some thoughts on this first.