I guess these are technically bugs, but there are no negative side effects. So more of a code clean up.

DatabaseTransaction::rollback() does not have any arguments and there are two watchdog keys specified.

watchdog_exception('fieldable_panels_panes', $e);
watchdog_exception('fieldable_panels_pane', $e);
CommentFileSizeAuthor
#2 fieldable_panels_pane-normalise-watchdog-key-remove-invalid-transaction-rollback-argument-1862130-2.patch593 bytesalan d.
fieldable_panels_pane-normalise-watchdog-key-remove-invalid-transaction-rollback-argument.patch826 bytesalan d.

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Let's standardize on the watchdog type of 'fieldable_panel_pane' which is used more through the module and matches the entity type. Otherwise this looks good.

alan d.’s picture

alan d. commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_pane-normalise-watchdog-key-remove-invalid-transaction-rollback-argument-1862130-2.patch593 bytes

re-roll :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #2 to 7.x-1.x. Thanks!
http://drupalcode.org/project/fieldable_panels_panes.git/commit/1bb6b5e

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.