First: thank you for this very useful module.
When I configure nodeprofile so that it
- shows the full node view on user/* pages, but
- does not show "edit" tab on the embedded node
I get the awkward view of the full node with a "view" tab, but no "edit" tab. This patch removes the "view" tab when there is no "edit" tab.
On a more general note: the settings on content type admin page are a little confusing. All configurations boil down to two options, don't they?
( ) embed profile on user page
( ) link to profile from user page
In the first case you would embed the profile on the user page in a full node view and you would edit the profile in the profile module way - on a tab on user/x/edit.
In the second case you would just have a link to the node.
What's not there is the teaser view of the node on a user profile... but is this a good use case?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | hide_view_tab_when_no_edit_tab.patch | 873 bytes | alex_b |
Comments
Comment #1
alex_b commentedForgot the patch, probably because it's so teeny weeny tiny.
Comment #2
fagoYep, I think it makes sense to have the teaser there, in particular for bigger profiles. You also forgot the option to disable the profile view on the user page :)
I agree that for the full node view the "View" link is unnecessary, but for the teaser view it is the only possibility to get to the full view. So it's needed. I already thought about adding another option for this, but that would clutter the settings even more. So people can override it by theming it.
However as an improvement I think it would be a good idea to change the default behaviour, so that the link is only shown alone when teaser view is activated.
Comment #3
fagoI've done so (hide the 'View' tab for the full node view on the user page, if there is no edit tab) -> committed to 5.x
Comment #4
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.