faq assumes that if i18n_select in enabled, that i18n_taxonomy is also enabled. This may not always be the case (it isn't in our setup).

CommentFileSizeAuthor
#7 faq-i18n_taxonomy_support-1862248-5-7.patch1.09 KBalex liannoy
#1 1862248-faq-i18n-taxonomy.patch1.02 KBmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new 1862248-faq-i18n-taxonomy.patch1.02 KB
sanchiz’s picture

sanchiz commented
Assigned: Unassigned » sanchiz
Issue summary: View changes
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs work » Needs review

triggering bot

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

this patch needs reroll

Status: Needs review » Needs work

The last submitted patch, 1: 1862248-faq-i18n-taxonomy.patch, failed testing.

alex liannoy’s picture

alex liannoy commented
Assigned: sanchiz » alex liannoy
Status: Needs work » Needs review
Issue tags: +dcuacs2015
StatusFileSize
new faq-i18n_taxonomy_support-1862248-5-7.patch1.09 KB
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented

Looks good to me, +1 to RTBC

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Assigned: alex liannoy » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +CodeSprintUA

thanks, merged

  • podarok committed 44b83d0 on 7.x-1.x authored by Lianik 
    Issue #1862248 by mrfelton, Lianik, Valentine94, danylevskyi: faq...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.