Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Dec 2012 at 14:38 UTC
Updated:
10 Sep 2018 at 00:26 UTC
Jump to comment: Most recent
Comments
Comment #1
mohs3n71 commentedhi ,
1 ) it seems that you are working in master branch , you should make a new branch for your module and work on it , some helpful links :
http://drupal.org/node/1127732
http://drupal.org/node/1015226
http://drupal.org/node/1066342
2 ) the README.txt file is missing , add a README file
3 ) automatic review found many problems with your code : http://ventral.org/pareview/httpgitdrupalorgsandboxowilliwo1858190git
please see drupal codding standards : http://drupal.org/node/318
Comment #2
lolandese commentedHi,
Can you explain the differences with http://drupal.org/project/scheduler?
Thanks.
Comment #3
owilliwoOK thanks, i didn't know about PAReview.
Comment #4
owilliwoMy module add a real published field date.
Drupal provide $entity->created, which contains creation date, not publication date.
You create a node, but you choose not to publish it immediatly on March 1st for example.
If you publish it on March 2nd, $node->created will be set to March 1st, although real_published_date will be set to March 2nd.
Comment #5
owilliwoGiven that $node->created may be modified manually by a user (if they have the correct permissions), and given that the Scheduler module functions in exactly the same manner as my module (in fact Scheduler does more things than mine), it seems that field_real_publised_date is no longer useful, as my module...
:(
Comment #6
lolandese commentedWith almost 20.000 modules, finding existing modules and monitoring new ones has become my daily 20 minute routine leading to ever expanding Google docs. One of my docs is keeping track of functionality I don't find, mostly related to existing modules (possible patches) with an occasional "stand-alone" functionality (possible modules). Of this last list often items get deleted because later I run into a module (or combination) that covers it anyway. So far I only found one functionality that was unique, was worth to write a module for and within my capabilities. In fact, most of my humble amount of contributing (every little bit helps) consists of patching, writing (documentation) and reviewing.
I hope this is of some consolation.
Consider changing the status of this issue.
Thanks.
Comment #7
owilliwoComment #7.0
owilliwoUpdate git address
Comment #8
avpaderno