Calling drupal_get_path() four times for the same theme is overkill, but it's really over the top when you're passed it as a variable.

CommentFileSizeAuthor
#1 fortyfour-1863280-1.patch1.23 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new fortyfour-1863280-1.patch1.23 KB

See attached.

ben.bunk’s picture

ben.bunk commented

+1

bryanhirsch’s picture

bryanhirsch commented
Status: Needs review » Closed (fixed)

Thanks tim.plunkett

http://drupalcode.org/project/fortyfour.git/commit/db90747

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (fixed) » Fixed

Thanks for the quick commit! You should mark issues fixed, the bot will come and mark them closed in 2 weeks (that helps people see recently fixed issues).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.