You should use a span or div set to invisible instead of text and background the same color. Text and background the same color will get you in trouble with the search engines

Comments

vm’s picture

vm commented

text and backgorund is also easily figured out by highlighting the blank area.

Zen’s picture

Zen commented
Title: Bad Idea » SEO implications
Version: 5.x-5.x-dev » 5.x-1.x-dev
Component: Miscellaneous » Code
Category: support » bug
Priority: Critical » Normal

@vsr:

a) I don't particularly care.
b) Please feel free to submit a patch that does not involve JS and retains usability.
c) This is legitimate use (like tons of other cases) and not keyword stuffing. These things are taken into account by search engines and in Google, from what I hear, false positives are checked for manually.
d) Lots of sites use similar implementations without repercussions. This is nothing new and is something users are also accustomed to (highlighting to read spoilers).

@verymisunderstood: huh?

Cheers :)
-K

Zen’s picture

Zen commented
Status: Active » Closed (works as designed)
murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented
Category: bug » feature
Status: Closed (works as designed) » Needs work

Spoiler is used for not hide text from reading, but for save page space via hiding text info hidden block. So hiding text with color text=background is not solve spoiler problem, instead of hide text for users, users see large empty gray rectangle!! And not each user know that for read text he must select it by mouse.
So, for js-disabled pages spoiler must not waste free space in page. Showing spoiler contents without js we can do via css, here is example:

<html>
<head>
<style>
div.spoiler div.spoiler-contents {
  display: none;
}

div.spoiler:hover div.spoiler-contents {
  display: block;
}
</style>
</head>
<body>
<div class=spoiler>
  <a href=# class=spoiler-link>Show spoiler</a>
  <div class=spoiler-contents>Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... Spoiler text... </div>
  
</div>
</body>
</html>

This way is working as designed in spoiler way without js, it much better that hiding text via colors.

Placing text with color=background on site is direct way to ban on google and other search engines!

Zen’s picture

Zen commented
Status: Needs work » Closed (works as designed)

The primary use of this module is to hide spoilers. In the rare event that the browser does not support JS or if JS has been disabled, the default is the only workable solution that I can think of to retain the functionality of this module. display:none is not acceptable as a default. You can, however, override this behaviour for your own site.

If you'd like to improve the default text displayed to users when JS is disabled, please create a separate issue for that request.

Thanks,
-K

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

Because this issue was closed as (works as designed), I do this feature in my sandbox: http://drupal.org/sandbox/murz/1492250 for Drupal 6.x and 7.x because I don't want to got ban my site in search engines.

Other users can download my version of this module from here ("snapshot" link):
For Drupal 6.x: http://drupalcode.org/sandbox/murz/1492250.git/tree/refs/heads/6.x-1.x
For Drupal 7.x: http://drupalcode.org/sandbox/murz/1492250.git/tree/refs/heads/7.x-1.x

jmdorian’s picture

jmdorian commented

It works, thanks.