This is a fairly minor bug with an easy workaround.

When adding a "Webform submission data" field in Views (which is totally freaking awesome btw!), if you select "No label" a label still shows. The workaround is to choose "Custom label" and then clear whatever is in the Label textbox, then select "No label" again and save.

CommentFileSizeAuthor
#5 webform-views_no_label-1864102-5.patch1.37 KBdanchadwick

Comments

mrpauldriver’s picture

mrpauldriver commented

I am finding the same and thank you for the workaround @nodecode

This needs fixing though.

mrpauldriver’s picture

mrpauldriver commented
Priority: Minor » Normal
Issue summary: View changes
AldenC’s picture

AldenC commented

Thank you very much for integrating Views into Webform 4.X. It opens up vast opportunties to manage submissions.

The Create a label option of "No label" does not work. I also first used a work-around by choosing "Custom label" and then setting it to "". But I decided to look a bit deeper and I found the culprit.

Line 103 of webform_handler_field_submission_data.inc which currently reads:
elseif (isset($this->options['label'])) {

apparently $this->options['label'] is populated on default so function label() never returns '' for the "No label" option. A simple solution is to change this line to read:
elseif ($this->options['custom_label'] === 'custom' && isset($this->options['label'])) {

There may be a better way to fix this, but this worked for me.

quicksketch’s picture

quicksketch
he/him
commented

Thanks @AldenC, that sounds like you're on the right track here. If this gets rolled as a patch I'll try it out and see if it solves the porblem.

danchadwick’s picture

danchadwick commented
Version: 7.x-4.0-alpha6 » 7.x-4.0-rc6
Status: Active » Fixed
StatusFileSize
new webform-views_no_label-1864102-5.patch1.37 KB

Committed to 7.x-4.x and 8.x.

  • DanChadwick committed a5549ab on 7.x-4.x 
    Issue #1864102 by DanChadwick: Fixed In Views, selecting "No label"...
  • DanChadwick committed 7d97e84 on 8.x-4.x
    Issue #1864102 by DanChadwick: Fixed In Views, selecting "No label"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.