Download & Extend
Issues

testPictureOnNodeComment doesn't actually test anything

Posted by alexpott on December 11, 2012 at 11:27pm
Project:Drupal core
Version:8.x-dev
Component:user.module
Category:bug report
Priority:normal
Assigned:alexpott
Status:needs review

Issue Summary

The default global theme setting for toggle_node_user_picture and toggle_comment_user_picture is TRUE so the test will always work. Even if you move theme settings out of variables and into CMI :)

Login or register to post comments

Comments

#1

Posted by alexpott on December 11, 2012 at 11:34pm
Status:active» needs review

Patch attached just removes the variable_set()'s to show that they have no effect on the outcome on the test.

AttachmentSizeStatusTest resultOperations
1864290-1.drupal8.user-picture-test.remove-vset.patch1.14 KBIdlePASSED: [[SimpleTest]]: [MySQL] 49,046 pass(es).View details | Re-test

#2

Posted by alexpott on December 11, 2012 at 11:35pm

Patch attached fixes the tests so that we are actually testing the ability to enable / disable user pictures on nodes and comments.

AttachmentSizeStatusTest resultOperations
1864290-2.drupal8.user-picture-test.patch1.65 KBIdlePASSED: [[SimpleTest]]: [MySQL] 49,347 pass(es).View details | Re-test

#3

Posted by alexpott on December 11, 2012 at 11:42pm

Bah... mistake in the comment for the new test that completely turns off user pictures..

AttachmentSizeStatusTest resultOperations
1864290-3.drupal8.user-picture-test.remove-vset.patch1.66 KBIdlePASSED: [[SimpleTest]]: [MySQL] 49,365 pass(es).View details | Re-test
nobody click here