Posted by mikesmullin on October 25, 2007 at 3:59am
Jump to:
| Project: | MySite |
| Version: | 5.x-2.14 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Why limit them to /mysite/USERNAME?
(see attached)
| Attachment | Size |
|---|---|
| mysite_6.patch | 3.85 KB |
Comments
#1
This came up before. See http://drupal.org/node/92415 for the logic. In summary, no one had a good use case for any path other than 'mysite/USERNAME'.
Since you've actually written the patch, I'm tempted to include it.
I'm working on a 5.x.3 release in HEAD, and this feature should probably go there. 5.x.2 is bugfix only.
#2
Path aliasing should remain a MySite option that is turned on and off. This patch removes Path from the options list if Pathauto is turned on.
I think that I'd like to see this as a setting for the path.inc file. I would also move most of the pathauto hook into path.inc, leaving just an include call and a stub function in the mysite.module.
#3
With pathauto, paths are turned on/off by whether or not you provide a pattern. It's simple, and I prefer things that way. Having two places to manage paths would just add to the level of complexity and confusion, so I opted to remove the stuff provided by path.inc but only when pathauto.module is enabled. (e.g. users without pathauto would not notice a difference)
For my use case, I set the pathauto pattern to: [user] (e.g. /mikesmullin or /agentrickard). Pathauto manages the renaming of duplicates and all that stuff, so this works well because it keeps user URLs nice and short. And, no offense, but I would rather not have the term 'mysite' visible anywhere in the URL. This makes for better private-labeling when you're using Drupal for enterprise-class solutions, like I am.
Hope this helps!
Great module! Keep up the good work...
#4
This patch is actually for 5.x-2.14. For some reason I thought the most recent version would appear at the top of the version dropdown...
#5
Yes, I get that. But I think I'd still like MySite admins to have to 'turn on' the Path include. Your patch currently disables that if Pathauto is installed.
By moving the pathauto hook into path.inc, we retain the current MySite admin UI.
#6
#7