eAssistancePro Live Chat

Hi eassistancepro,

Add README.txt to your project and fix the coding issues i found with
ventral.org/pareview/httpgitdrupalorgsandboxeassistancepro1847610git

FILE: ...all/modules/pareview_temp/test_candidate/eassistance_pro_live_chat.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | "description" property is missing in the info file
1 | ERROR | "core" property is missing in the info file
--------------------------------------------------------------------------------

Every time you make modification in the code before set the status to "needs review" first run this check to be sure that you don't have any issue.

With Respect,
balintcsaba

Hi,

You still have the errors , please fix it before you put your status back to needs review.

Use the http://ventral.org/pareview/httpgitdrupalorgsandboxeassistancepro1847610git how i told you before.
Do so every time you make a git pull to check if you don't have any errors on the code. Or we will stuck in a circle.

Hi,

I checked and now i find a huge list of errors.
Maybe you don't understood me at first , so i will repeat the steps.
When you do a git pull alleyways run the code checker after it, you can do it yourself.
Just click at this link: http://ventral.org/pareview/httpgitdrupalorgsandboxeassistancepro1847610git
(this is your project code) and click to Repeat Preview TAB , and fix does errors.
Just when you have a clean code put back to needs review.

Also remove "version" from the info file, it will be added by drupal.org packaging automatically.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hi,

I wen't through each file and found these things that could be considered.

in eassistancepro.admin.inc:
-You have some #description in your form with an empty string passed to t().
-Your doc blocks missing are missing information about what hook they implement on every function
-The form configuration has a few #size attributes, which are strings, should be integer.

eassistancepro.install
-I don't understand why you call variable_get() in your install hook.

eassistancepro.module
-The first hook that you're implementing hook_menu has a correct doc block, the other hooks in the file does not.
-In the #description attribute you have a space before the last dot in the string, should be passed through t()
-You are using an access argument but it's not defined in a hook_permission() does this work?

eassistancepro.php
-Javascript should be included with drupal_add_js()

Regards,

Troels

Manual Review:

eassistancepro.admin.inc:
- Line 11: Unused global variable $languge.
- Line 23: In l() use option 'absolute' instead of adding $base_url manually.
- Line 79: Why are there 6 spaces between the string concationation? (' . $data[')
- Line 86-89: Do not set data in the validation hook. Submit should be used here. Because other validation function could be failing. system_settings_form sets variables automaticlly after the name used for the form element. For the username and mid add this to your $data['values'] array - see http://api.drupal.org/api/drupal/modules!system!system.module/function/s...

eassistancepro.install.inc:
- You do not need to initalizie empty variables on install.

eassistancepro.module:
- I think you don't need the require if it is in the info file added as file[].
- Minor spelling errors: "Craete" (Create) and "hoke" (hook)

eassistancepro.php:
- Minor spelling errors: "Declatre" (Declare)
- Line 80: Use block_load instead of creating the query manually - http://api.drupal.org/api/drupal/modules!block!block.module/function/blo...
- Line 94, 96: Unused variables $eassistancepro_account_info, $eassistancepro_password

Recommendations:

• Give users the option to place this module in Blocks instead of having to use the HTML code provided.
• When entering my assistance login information, I received the PHP error: eassistancepro_admin_settings_form_validate() (line 85 of .../modules/eAssistancePro/eassistancepro.admin.inc)
• Icon still reads offline even though my eAssistancePro account is online and is hard to access the live chat through the eAssistance website.
• Integrate better configuration so that the user can adjust the module and icon to their specific needs.
• Visually change the Live Chat icon when the operator is online and offline. Include a graphical change such as a red icon when offline.
• Allow users to rate the operator they just spoke to after the chat session is completed.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Very nice features available in the software. I like proactive chat and customizable chat window features. Now they have integrated new features of Social media integration (Integrate live chat software on your Facebook fan page) on their live chat. I think this is the best live chat available on the market on very low price.

add repository clone link