Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Create a node, add a comment, switch to the chameleon theme, and try to view the node. Result: "Fatal error: Unsupported operand types in /.../includes/common.inc on line 1387"
Fix that, and you get these:
* notice: Undefined variable: signature in /.../themes/chameleon/chameleon.theme on line 163.
* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /.../themes/chameleon/chameleon.theme on line 170.
Attached patch fixes all the above
Comment | File | Size | Author |
---|---|---|---|
chameleon_comment.patch | 1.35 KB | John Morahan | |
Comments
Comment #1
John Morahan CreditAttribution: John Morahan commentedComment #2
catchTested with and without patch, gets rid of the error and the fix looks sensible (although I have no idea about non-phptemplate themes in general).
Comment #3
Gábor HojtsyIndeed, theme_comment parameters are not properly used here (as defined in comment_theme() in comment.module).
So adding the node between the comment and the links seems to be correct.
l() was also changed to have
l($text, $path, $options = array())
so that fix also look correct.Then what remains is an E_ALL fix, so committed.
Thanks for the patch!
Comment #4
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.