Create a node, add a comment, switch to the chameleon theme, and try to view the node. Result: "Fatal error: Unsupported operand types in /.../includes/common.inc on line 1387"
Fix that, and you get these:
* notice: Undefined variable: signature in /.../themes/chameleon/chameleon.theme on line 163.
* warning: array_merge() [function.array-merge]: Argument #2 is not an array in /.../themes/chameleon/chameleon.theme on line 170.
Attached patch fixes all the above

CommentFileSizeAuthor
chameleon_comment.patch1.35 KBjohn morahan

Comments

john morahan’s picture

john morahan commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Tested with and without patch, gets rid of the error and the fix looks sensible (although I have no idea about non-phptemplate themes in general).

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Indeed, theme_comment parameters are not properly used here (as defined in comment_theme() in comment.module).

  'comment' => array(                                                                                
      'template' => 'comment',                                                                         
      'arguments' => array('comment' => NULL, 'node' => NULL, 'links' => array()),                     
    ),

So adding the node between the comment and the links seems to be correct.

l() was also changed to have l($text, $path, $options = array()) so that fix also look correct.

Then what remains is an E_ALL fix, so committed.

Thanks for the patch!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.