The name of your module: Commerce Amount Coupon
A detailed description of what it does: Generate coupons, administer and see them in action in your drupal commerce shop.

Link to sandbox project: Sandbox

The intended Drupal core version 7.x

Comments

stijn.blomme’s picture

stijn.blomme commented

hi Xvendo

automated review

- the automated test returned quite a lot of errors
http://ventral.org/pareview/httpgitdrupalorgsandboxxvendo1864598git

functionality test

- the module seems to work
--> you still have calls to dsm() -> this will throw errors on sites without devel installed (line 522)

manual review

- your code is currently on a master branch -> this should be changed to 7.x-1.x
- please add a README.txt file to your module

- the function function commerce_amount_coupon_configure_line_item() is fully commented this can probably be deleted?

- you have a lot of functions that are not prefaced with your module name

- please add a git link to your post

- could you give us some more information about the differences between this module and commerce_coupon? (http://drupal.org/project/commerce_coupon)
-> what are the differences?
-> what are some use cases for this module in favour of commerce_coupon?
-> wouldnt it be possible to just commit changes to the existing module?

stijn.blomme’s picture

stijn.blomme commented
Status: Active » Needs work
globexplorer’s picture

globexplorer commented

could you give us some more information about the differences between this module and commerce_coupon?

Commerce_coupon is not a standalone module. For fixed amount coupons you would have to install http://drupal.org/project/commerce_coupon_fixed_amount.

The main difference is the handling. Many people do not understand rules, and they want an easy to use module for coupons. This module do not make any use of rules, and people do not have to care about rules at all. They can just enable this module and use it.

This module is sponsored by cyLEDGE a creative company who runs www.cowcrowd.com, and the use of commerce_coupon made a lot of problems, because of the complex use of rules.

Problems of rules:
The rules module is great, but when it gets a little bit more complex it is unusable! Especially when you have so many things to take care of.

wouldnt it be possible to just commit changes to the existing module?
No, because the module is fully rules based. And we have to offer people an alternative to rules based modules.

Link:
https://drupal.org/sandbox/xvendo/1864598

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

globexplorer’s picture

globexplorer commented
Status: Closed (won't fix) » Needs review
rajeevk’s picture

rajeevk
Location London
commented
Status: Needs review » Needs work

Hello xvendo,

It's a nice module as I can see. Please ensure your code pass automated testing.

Automated Review

Throw so many error. Have a look --

http://ventral.org/pareview/httpgitdrupalorgsandboxxvendo1864598git

Manual Review

- You are still using master branch. Please change it to 7.x-1.x.
- Change the name README.TXT to README.txt
- These functions that are not prefaced with your module name:

function coupon_code_validation($element, &$form_state, $form)
function check_coupon_status($status)
function check_type($type)
function check_order($order_id)
function delete_coupons($record_id)
function commerce_amount_create_new_percentage_coupon()
function commerce_amount_create_new_fixed_coupon()
function commerce_amount_create_new_fixed_coupon_submit($form, &$form_state)
function commerce_amount_create_new_percentage_coupon_submit($form, &$form_state)
function generateCoupons($coupon_name, $currency_code, $coupon_amount, $coupon_code, $min_order_amount, $total_number_of_coupons, $coupon_code_digits)
function generateCouponsPercentage($coupon_name, $coupon_percentage, $min_order_amount, $coupon_code, $total_number_of_coupons, $coupon_code_digits)
function randomizeCoupon($length)
function set_coupon_code_to_used($coupon_code, $currency, $order_number)
function get_coupon_code_value($coupon_code, $currency)

Functional Review

- Warning while enabling module:
Warning: Illegal string offset 'type' in commerce_product_line_item_configuration() (line 1125 of /var/www/indiaread-dev/sites/all/modules/commerce/modules/product_reference/commerce_product_reference.module).

Please have a look & change status..

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.