Some settings like DOMAIN_INSTALL_RULE or DOMAIN_SITE_GRANT need to be modified in the domain.module to take effect. In my opinion, these constants should be overridden in Drupal settings.php, so that we don't need to change the module's source code. If so, we don't need to modify the source whenever the module is upgraded to newer version.

Just modify the domain.module like below:

if (!defined('DOMAIN_INSTALL_RULE')) 
   define('DOMAIN_INSTALL_RULE', TRUE);

Comments

agentrickard’s picture

Makes sense to me. We really need to phase these out, actually.

Can you roll patches against the 3 active branches, please.

sonnykt’s picture

Here are the patches for all 3 branches

agentrickard’s picture

Status: Active » Needs work

Nice. But Drupal convention is never to use one-line IF statements.

bluegeek9’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 7 in End of Life and no longer supported. We encourage you to upgrade to a supported version of Drupal. For more information, see https://www.drupal.org/upgrade.

//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support of this project makes other volunteer contributions more sustainable.
There are multiple ways to show appreciation for the work contributed to this project, including:
  • Triaging issues and adding more context to existing issues.
  • Writing documentation or patches for this project.